Refactor audio engine module, replace backend with OpenAL for android#18961
Refactor audio engine module, replace backend with OpenAL for android#18961halx99 wants to merge 2 commits into
Conversation
|
This is also big pull request. It seems like you move lots of files around... Please check Travis build cocos_new fails because new files were added and Json file was not updated. |
|
Well, tody, I have test OpenAL + mpg123 + ogg on ubuntu 18.04, use the same source with win32, it's works fine. |
|
I think that there is one problem with mpg123: "licensed under LGPL 2.1" |
|
mpg123 just a decoder, and ogg is free.OpenAL is MIT. |
|
@halx99 Please check: https://github.com/cocos2d/cocos2d-x/blob/v3/docs/CODING_STYLE.md
|
|
@drelaptop @minggo Please check carefully this PR and cocos2d/cocos2d-x-3rd-party-libs-bin#317 |
|
One more thing: for Android game size critical! This PR:
|
|
On how many Android devices that was tested? What is performance? |
|
Well, due to the license limition, this PR may need close currently before we can find a non LGPL solution for both win32,android,linux platforms |
|
However, LGPL can be used at commercial witout midification and linked as shared library. I will continue working for this. If you are interested and don't care about android apk size increase, you can track here: https://github.com/halx99/x-studio365/tree/master/cocos2d-x-patch/cocos/audio |
|
@halx99 Could you create pull request for Linux only? mpg123 and openal is already used for win32. |
|
Since, our project is published at china, the OpenAL backend run at thousands of android devices. From our bugly statistics, it's very stable. |
… platform.