Skip to content

Conversation

@sonicfromnewyoke
Copy link
Contributor

@sonicfromnewyoke sonicfromnewyoke commented May 22, 2025

Problem

renderers-rust and renderers-vixen-parser use bloated solana-sdk and solana-program crates

Solution

replace solana-sdk and solana-program by smaller creates which leads to faster compilation time and smaller bin sizes according to solana-sdk-crate-migration-guide

also solana-* crates were bumped to the ~v2.2

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2025

🦋 Changeset detected

Latest commit: f6ee63f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@codama/renderers-rust Minor
@codama/renderers-vixen-parser Minor
@codama/cli Patch
@codama/renderers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sonicfromnewyoke sonicfromnewyoke marked this pull request as ready for review May 22, 2025 21:24
Copy link
Contributor

@fernandodeluret fernandodeluret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the perspective of renderers-vixen-parser (and the use we do there of renderers-rust) this is LGTM! 🤝 ❤️

Copy link
Member

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we’ve actually already got this done for solana-pubkey (#535) in a dedicated branch (renderers-rust/use-granular-crates) in the hope to tackle more granular crates as they get released. This is mainly so we can do a single breaking change for the Rust renderer for all these changes. Would you be able to submit multiple PRs for the other crates into this branch? Then we can publish the whole branch when it’s ready.

@sonicfromnewyoke
Copy link
Contributor Author

Thanks, we’ve actually already got this done for solana-pubkey (#535) in a dedicated branch (renderers-rust/use-granular-crates) in the hope to tackle more granular crates as they get released. This is mainly so we can do a single breaking change for the Rust renderer for all these changes. Would you be able to submit multiple PRs for the other crates into this branch? Then we can publish the whole branch when it’s ready.

oh yeah, no problem. I didn't know about this branch. So, if i got you correctly there will be 1 dedicated MR for 1 solana-* create, right?

@lorisleiva
Copy link
Member

Yeah that'd be great. That way it's easier to review and we can provide more digestible changelogs.

@lorisleiva
Copy link
Member

Thank you for making progress on these smaller PRs! I'll close this since we're making progress in different PRs instead of this one.

See #641, #645.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants