-
Notifications
You must be signed in to change notification settings - Fork 64
feat: replace solana-program with pubkey/account-info/instruction crates #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace solana-program with pubkey/account-info/instruction crates #616
Conversation
🦋 Changeset detectedLatest commit: f6ee63f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fernandodeluret
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the perspective of renderers-vixen-parser (and the use we do there of renderers-rust) this is LGTM! 🤝 ❤️
lorisleiva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, we’ve actually already got this done for solana-pubkey (#535) in a dedicated branch (renderers-rust/use-granular-crates) in the hope to tackle more granular crates as they get released. This is mainly so we can do a single breaking change for the Rust renderer for all these changes. Would you be able to submit multiple PRs for the other crates into this branch? Then we can publish the whole branch when it’s ready.
oh yeah, no problem. I didn't know about this branch. So, if i got you correctly there will be 1 dedicated MR for 1 |
|
Yeah that'd be great. That way it's easier to review and we can provide more digestible changelogs. |
Problem
renderers-rustandrenderers-vixen-parseruse bloatedsolana-sdkandsolana-programcratesSolution
replace
solana-sdkandsolana-programby smaller creates which leads to faster compilation time and smaller bin sizes according to solana-sdk-crate-migration-guidealso
solana-*crates were bumped to the~v2.2