chore(release): update pypi packaging

[thomasrockhu-codecov]

• splits build_assets and build_for_pypi into separate workflows that run on
• they also run on new tags
• adds pyproject.toml because its what should be used over setup.py
• splits the build and deploy job for the build_for_pypi workflow
• small opentelem thing to not run on tests

fixes #466

[codecov]

❌ 5 Tests Failed:

Tests completed	Failed	Passed	Skipped
3560	5	3555	0

View the top 3 failed tests by shortest run time

api.temp.calculator.test_calculator::test_divide

Stack Traces | 0.001s run time

def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

api.temp.calculator.test_calculator::test_divide

Stack Traces | 0.001s run time

def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

api.temp.calculator.test_calculator::test_divide

Stack Traces | 0.001s run time

def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

[github-actions]

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

[webknjaz]

If the Python version in this job is 3.11+, you can just use the stdlib module for reading TOML:

Suggested change

	echo previous_version=$(git tag --sort=-creatordate | head -n 2 | tail -n 1) >> "$GITHUB_OUTPUT"
	echo previous_version=$(git tag --sort=-creatordate | head -n 2 | tail -n 1) >> "$GITHUB_OUTPUT"
	- name: Extract hardcoded dist version from PEP 621 config
	id: dist-meta
	run: |
	from os import environ
	from pathlib import Path
	from tomllib import loads as convert_toml_text_to_dict
	FILE_APPEND_MODE = 'a'
	pyproject_toml_txt = Path("pyproject.toml").read_text(encoding="utf-8")
	pyproject_toml = convert_toml_text_to_dict(pyproject_toml_txt)
	version_string = pyproject_toml["project"]["version"]
	with Path(environ['GITHUB_OUTPUT']).open(
	mode=FILE_APPEND_MODE,
	) as outputs_file:
	print(f'release-version={version_string !s}', file=outputs_file)
	shell: python

(if not — call actions/setup-python earlier to ensure it's modern enough)

[webknjaz]

(note that I'm setting release-version over release_version, and a new step ID here because it's usually helpful to have kebab-case identifiers in GHA, making it easier to distinguish them from identifiers from other embedded scripts)

[webknjaz]

@thomasrockhu-codecov short of the broken regex, the rest should be ready even without implementing improvement suggestions in other comments — they can be declared out of the scope and filed as separate issues, I suppose.

[webknjaz]

you can email me at [email protected].

Thanks! I've emailed you.

[webknjaz]

Just realized that the environment isn't set. Here's a patch to fix this. Additionally, add required reviewers to the environment called pypi in the repo settings.

[webknjaz]

@thomasrockhu-codecov additionally to that incorrect URL that I suggested initially, could you confirm you've enabled required reviewers in the environment called pypi? There's been discussions about this topic recently, when TP was being integrated into pip: pypa/pip#13048 (comment). I recommend having this gate just to be in control of the process.

[thomasrockhu-codecov]

@webknjaz

[webknjaz]

LGTM