-
Notifications
You must be signed in to change notification settings - Fork 54
Remove tree-sitter
and associated build infrastructure
#664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
63b952e
to
30086d4
Compare
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
30086d4
to
73ad399
Compare
93be38c
to
6b6b9da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, can you update the build_assets.yml
to run on
on:
push:
- swatinem/rm-treesitter
to see if this workflow will run, can delete after once the artifacts are created and test one out locally
221cc55
to
3e4ac36
Compare
.github/workflows/build_assets.yml
Outdated
mv dist/main dist/codecovcli_macos && | ||
lipo -archs dist/codecovcli_macos | grep 'x86_64 arm64' | ||
OUT_FILE_NAME: codecovcli_macos | ||
ASSET_MIME: application/octet-stream | ||
- os: ubuntu-20.04 | ||
- os: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we used 20.04
specifically for some reason, I probably would change this to 22.04
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending the change to 22.04
The static-analysis command previously depended on tree-sitter, which required building some C-based extensions coming from submodules. Now that static-analysis is gone, we can also remove `tree-sitter` and all associated build complexity.
4e784f0
to
f17c41b
Compare
Reapplies @Swatinem's diff from codecov/codecov-cli#664
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Swatinem you could've just deleted this file for good as a part of this patch. There's no use for it once you're done with the C-extensions.
@Swatinem there's also leftover jobs @ https://github.com/codecov/codecov-cli/blob/main/.github/workflows/build_for_pypi.yml |
The static-analysis command previously depended on tree-sitter, which required building some C-based extensions coming from submodules.
Now that static-analysis is gone, we can also remove
tree-sitter
and all associated build complexity.