Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tree-sitter and associated build infrastructure #664

Draft
wants to merge 2 commits into
base: swatinem/noop-ats
Choose a base branch
from

Conversation

Swatinem
Copy link
Contributor

The static-analysis command previously depended on tree-sitter, which required building some C-based extensions coming from submodules.

Now that static-analysis is gone, we can also remove tree-sitter and all associated build complexity.

This rips out all of `static-analysis`, but keeps the treesitter `languages` and associated build infrastructure for now.

Ripping out `label-analysis` works rather by running the fallback code unconditionally without making requests to the backend API.
The static-analysis command previously depended on tree-sitter, which required building some C-based extensions coming from submodules.

Now that static-analysis is gone, we can also remove `tree-sitter` and all associated build complexity.
@Swatinem Swatinem self-assigned this Mar 20, 2025
Copy link

codecov bot commented Mar 20, 2025

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
3420 5 3415 0
View the top 3 failed test(s) by shortest run time
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant