Skip to content

Remove tree-sitter and associated build infrastructure #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025

Conversation

Swatinem
Copy link
Contributor

The static-analysis command previously depended on tree-sitter, which required building some C-based extensions coming from submodules.

Now that static-analysis is gone, we can also remove tree-sitter and all associated build complexity.

@Swatinem Swatinem self-assigned this Mar 20, 2025
Copy link

codecov bot commented Mar 20, 2025

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
3435 5 3430 5
View the top 3 failed test(s) by shortest run time
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@Swatinem Swatinem force-pushed the swatinem/noop-ats branch from 30086d4 to 73ad399 Compare April 28, 2025 12:18
Base automatically changed from swatinem/noop-ats to main April 29, 2025 08:36
@Swatinem Swatinem force-pushed the swatinem/rm-treesitter branch from 93be38c to 6b6b9da Compare April 29, 2025 08:38
@Swatinem Swatinem marked this pull request as ready for review April 29, 2025 08:38
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, can you update the build_assets.yml to run on

on:
  push:
    - swatinem/rm-treesitter

to see if this workflow will run, can delete after once the artifacts are created and test one out locally

@Swatinem Swatinem force-pushed the swatinem/rm-treesitter branch 2 times, most recently from 221cc55 to 3e4ac36 Compare May 8, 2025 08:46
mv dist/main dist/codecovcli_macos &&
lipo -archs dist/codecovcli_macos | grep 'x86_64 arm64'
OUT_FILE_NAME: codecovcli_macos
ASSET_MIME: application/octet-stream
- os: ubuntu-20.04
- os: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we used 20.04 specifically for some reason, I probably would change this to 22.04 instead

Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the change to 22.04

Swatinem added 2 commits May 9, 2025 08:20
The static-analysis command previously depended on tree-sitter, which required building some C-based extensions coming from submodules.

Now that static-analysis is gone, we can also remove `tree-sitter` and all associated build complexity.
@Swatinem Swatinem merged commit 4d64989 into main May 12, 2025
22 of 23 checks passed
@Swatinem Swatinem deleted the swatinem/rm-treesitter branch May 12, 2025 19:38
spalmurray added a commit to getsentry/prevent-cli that referenced this pull request May 15, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Swatinem you could've just deleted this file for good as a part of this patch. There's no use for it once you're done with the C-extensions.

@webknjaz
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants