Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Node 22 LTS #3507

Merged
merged 6 commits into from
Dec 10, 2024
Merged

dev: Node 22 LTS #3507

merged 6 commits into from
Dec 10, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Nov 16, 2024

Description

This PR updates our gazebo node version from 20 -> 22, including updates to volta and nvmrc, as well as the dockerfile.

No functional changes, alpine version was updated as well for the docker image.

Alpine changelog -> All security/bug fixes from 3.17 -> 3.20

Node 22 LTS announcement

Closes codecov/engineering-team#2937

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Nov 16, 2024

Bundle Report

Changes will decrease total bundle size by 6.14MB (-35.03%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push (removed) 6.14MB (-100.0%) ⬇️

@codecov-staging
Copy link

codecov-staging bot commented Nov 16, 2024

Bundle Report

Changes will decrease total bundle size by 6.14MB (-35.03%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-array-push (removed) 6.14MB (-100.0%) ⬇️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 16, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
d5dc867 Sat, 16 Nov 2024 00:08:11 GMT Expired Expired
d5dc867 Sat, 16 Nov 2024 00:08:49 GMT Expired Expired
d5dc867 Sat, 16 Nov 2024 00:09:58 GMT Expired Expired
732874e Sat, 16 Nov 2024 00:20:46 GMT Expired Expired
41b3fb9 Mon, 09 Dec 2024 21:01:56 GMT Cloud Enterprise

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (b4e0043) to head (41b3fb9).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3507   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14484    14484           
  Branches     4111     4111           
=======================================
  Hits        14326    14326           
  Misses        151      151           
  Partials        7        7           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e0043...41b3fb9. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (b4e0043) to head (41b3fb9).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3507   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14484    14484           
  Branches     4111     4118    +7     
=======================================
  Hits        14326    14326           
  Misses        151      151           
  Partials        7        7           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e0043...41b3fb9. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3507   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14484    14484           
  Branches     4118     4111    -7     
=======================================
  Hits        14326    14326           
  Misses        151      151           
  Partials        7        7           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e0043...41b3fb9. Read the comment docs.

@ajay-sentry ajay-sentry added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 8e7be0e Dec 10, 2024
63 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/node-22 branch December 10, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Node Version from 20 (Maintenance) to 22 (LTS)
4 participants