Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Node 22 LTS #3507

Merged
merged 6 commits into from
Dec 10, 2024
Merged

dev: Node 22 LTS #3507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
112518f
node 22 update
ajay-sentry Nov 15, 2024
8b89e79
forgot to update engine and npm package types
ajay-sentry Nov 16, 2024
d5dc867
forgot to change this to 20 from 19
ajay-sentry Nov 16, 2024
732874e
use 3.17 on not node image
ajay-sentry Nov 16, 2024
37141cd
Merge branch 'main' into Ajay/node-22
ajay-sentry Dec 9, 2024
41b3fb9
tsc fixes for storybook files
ajay-sentry Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v20.15.1
v22.11.0
2 changes: 1 addition & 1 deletion .storybook/Layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react'
import '../src/globals.css'

const Layout = ({ children }) => {
const Layout: React.FC<React.PropsWithChildren> = ({ children }) => {
return <div className="text-sm text-ds-primary-base">{children}</div>
}

Expand Down
4 changes: 2 additions & 2 deletions .storybook/preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ export const parameters = {

const queryClient = new QueryClient()

const localStorageResetDecorator = (Story) => {
const localStorageResetDecorator = (Story: React.FC) => {
window.localStorage.clear()
return <Story />
}

export const decorators = [
localStorageResetDecorator,
(Story) => (
(Story: React.FC) => (
<QueryClientProvider client={queryClient}>
<Layout>
<Story />
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ RUN gpg --verify linux/codecov.SHA256SUM.sig linux/codecov.SHA256SUM

COPY docker/index.html /tmp/uploader

FROM node:20-alpine3.17 as build
FROM node:22-alpine3.20 as build
ARG REACT_APP_ENV_ARG
ARG REACT_APP_CODECOV_VERSION
ENV REACT_APP_ENV=$REACT_APP_ENV_ARG
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
"@types/eslint-plugin-jsx-a11y": "^6.9.0",
"@types/js-cookie": "3.0.6",
"@types/lodash": "4.17.6",
"@types/node": "^20.5.7",
"@types/node": "^22.9.0",
"@types/prismjs": "^1.26.4",
"@types/prop-types": "15.7.12",
"@types/qs": "6.9.15",
Expand Down Expand Up @@ -170,13 +170,13 @@
"vitest": "^2.1.3"
},
"engines": {
"node": ">=20.10.0"
"node": ">=22.11.0"
},
"msw": {
"workerDirectory": "public"
},
"volta": {
"node": "20.15.1",
"node": "22.11.0",
"yarn": "4.5.0"
},
"resolutions": {
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
"types": ["./src/types"]
}
},
"include": ["src"],
"include": ["src", ".storybook/**/*"],
"exclude": ["node_modules", "dist", "public"]
}
15 changes: 12 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6609,7 +6609,7 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:*, @types/node@npm:^20.5.7":
"@types/node@npm:*":
version: 20.14.10
resolution: "@types/node@npm:20.14.10"
dependencies:
Expand Down Expand Up @@ -6645,6 +6645,15 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:^22.9.0":
version: 22.9.0
resolution: "@types/node@npm:22.9.0"
dependencies:
undici-types: "npm:~6.19.8"
checksum: 10c0/3f46cbe0a49bab4ba30494025e4c8a6e699b98ac922857aa1f0209ce11a1313ee46e6808b8f13fe5b8b960a9d7796b77c8d542ad4e9810e85ef897d5593b5d51
languageName: node
linkType: hard

"@types/parse-json@npm:^4.0.0":
version: 4.0.2
resolution: "@types/parse-json@npm:4.0.2"
Expand Down Expand Up @@ -10361,7 +10370,7 @@ __metadata:
"@types/eslint-plugin-jsx-a11y": "npm:^6.9.0"
"@types/js-cookie": "npm:3.0.6"
"@types/lodash": "npm:4.17.6"
"@types/node": "npm:^20.5.7"
"@types/node": "npm:^22.9.0"
"@types/prismjs": "npm:^1.26.4"
"@types/prop-types": "npm:15.7.12"
"@types/qs": "npm:6.9.15"
Expand Down Expand Up @@ -16342,7 +16351,7 @@ __metadata:
languageName: node
linkType: hard

"undici-types@npm:~6.19.2":
"undici-types@npm:~6.19.2, undici-types@npm:~6.19.8":
version: 6.19.8
resolution: "undici-types@npm:6.19.8"
checksum: 10c0/078afa5990fba110f6824823ace86073b4638f1d5112ee26e790155f481f2a868cc3e0615505b6f4282bdf74a3d8caad715fd809e870c2bb0704e3ea6082f344
Expand Down
Loading