-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update useBundleAssets to fetch routes field #3527
feat: Update useBundleAssets to fetch routes field #3527
Conversation
Bundle ReportChanges will decrease total bundle size by 460 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3527 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 808 808
Lines 14411 14411
Branches 4091 4098 +7
=======================================
Hits 14256 14256
Misses 148 148
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3527 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 808 808
Lines 14414 14414
Branches 4099 4099
=======================================
Hits 14260 14260
Misses 147 147
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3527 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 808 808
Lines 14411 14411
Branches 4098 4098
=======================================
Hits 14256 14256
Misses 148 148
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 460 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
eb4e8e2
to
02be838
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3527 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 808 808
Lines 14411 14411
Branches 4091 4098 +7
=======================================
Hits 14256 14256
Misses 148 148
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Description
This PR updates the
useBundleAssets
hook to also fetch the newly introducedroutes
field on theBundleAsset
type. This will be used to populate later on in the new column we're going to be adding to the assets table on the bundles tab.Closes codecov/engineering-team#2956
Notable Changes
routes
field inuseBundleAssets