Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update useBundleAssets to fetch routes field #3527

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates the useBundleAssets hook to also fetch the newly introduced routes field on the BundleAsset type. This will be used to populate later on in the new column we're going to be adding to the assets table on the bundles tab.

Closes codecov/engineering-team#2956

Notable Changes

  • Update query and schema with new routes field in useBundleAssets
  • Update tests

@codecov-staging
Copy link

codecov-staging bot commented Nov 26, 2024

Bundle Report

Changes will decrease total bundle size by 460 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.63MB 2 bytes (-0.0%) ⬇️
gazebo-staging-system 5.58MB 458 bytes (-0.01%) ⬇️

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3527   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         808      808           
  Lines       14411    14411           
  Branches     4091     4098    +7     
=======================================
  Hits        14256    14256           
  Misses        148      148           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/bundleAnalysis/useBundleAssets.tsx 94.73% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa0c312...02be838. Read the comment docs.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (2a65caa) to head (eb4e8e2).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3527   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         808      808           
  Lines       14414    14414           
  Branches     4099     4099           
=======================================
  Hits        14260    14260           
  Misses        147      147           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/bundleAnalysis/useBundleAssets.tsx 97.14% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a65caa...eb4e8e2. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 26, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
eb4e8e2 Tue, 26 Nov 2024 16:28:08 GMT Expired Expired
02be838 Tue, 26 Nov 2024 17:42:58 GMT Cloud Enterprise

@codecov-qa
Copy link

codecov-qa bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (aa0c312) to head (02be838).
Report is 25 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3527   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         808      808           
  Lines       14411    14411           
  Branches     4098     4098           
=======================================
  Hits        14256    14256           
  Misses        148      148           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/bundleAnalysis/useBundleAssets.tsx 94.73% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa0c312...02be838. Read the comment docs.

Copy link

codecov bot commented Nov 26, 2024

Bundle Report

Changes will decrease total bundle size by 460 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.58MB 458 bytes (-0.01%) ⬇️
gazebo-production-system-esm 5.63MB 2 bytes (-0.0%) ⬇️

@nicholas-codecov nicholas-codecov force-pushed the gh-eng-2956-update-use-bundle-assets-to-fetch-routes branch from eb4e8e2 to 02be838 Compare November 26, 2024 17:33
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit e3294d3 Dec 6, 2024
53 of 54 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-2956-update-use-bundle-assets-to-fetch-routes branch December 6, 2024 11:29
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (aa0c312) to head (02be838).
Report is 25 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3527   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         808      808           
  Lines       14411    14411           
  Branches     4091     4098    +7     
=======================================
  Hits        14256    14256           
  Misses        148      148           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/bundleAnalysis/useBundleAssets.tsx 94.73% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa0c312...02be838. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Update useBundleAssets to grab new routes field
3 participants