-
Notifications
You must be signed in to change notification settings - Fork 53
Clarify scope of the task in #hd5 Multi Replica Command Propagation #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ion in course-definition.yml
WalkthroughThe description for the "Multi Replica Command Propagation" stage in the replication extension was updated to clarify that the implementation changes are required only on the master side, with no changes needed on the replica side. No functional requirements or control flow were altered. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note added
… course-definition.yml
course-definition.yml
Outdated
@@ -1514,6 +1514,9 @@ stages: | |||
``` | |||
|
|||
It'll then assert that each replica received those commands, in order. | |||
|
|||
### Notes | |||
- There is no need to change anything in the replica implementation for this stage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"There is no need" is a bit unclear and vague - first question a person would ask is "why is there no need?"
Can't think of a clean neat sentence to improve off the top of my head - @andy1li do you want to come up with a few options here? Also worth looking at our other stage instructions to see if we already have something similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Options:
- No changes are needed in the replica implementation for this stage. You’ll handle that in the upcoming stages.
- For this stage, focus only on the master. Changes to the replica will be covered in the upcoming stages.
- This stage doesn’t require any changes to the replica implementation. You’ll handle that soon.
Existing instructions:
https://app.codecrafters.io/courses/interpreter/stages/xc5:
In this stage, you'll add support for scanning other single-character tokens, namely ,, ., -, +, ; and *. / is not covered here, it's covered in later stages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted to just adding "master" to the hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note added
…urse-definition.yml
Thanks @rahmonov for highlighting the issue! |
Awesome! Glad I could help. |
Context:
https://backend.codecrafters.io/admin/course_stage_feedback_submissions/4b9b754d-ce28-423a-8a09-0c0b03c3b2fa/edit
Summary by CodeRabbit