Skip to content

Clarify scope of the task in #hd5 Multi Replica Command Propagation #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

Clarify scope of the task in #hd5 Multi Replica Command Propagation #304

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10f115a
fix: Clarify master implementation for multi-replica command propagat…
andy1li May 13, 2025
fd7dea9
fix: Add clarification notes for multi-replica command propagation in…
andy1li May 14, 2025
70cc0ed
refactor: Remove unnecessary notes about replica implementation in co…
andy1li May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion course-definition.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,7 +1486,7 @@ stages:
name: "Multi Replica Command Propagation"
difficulty: hard
description_md: |
In this stage, you'll extend your implementation to support propagating commands to multiple replicas.
In this stage, you'll extend your implementation of the master to support propagating commands to multiple replicas.

### Tests

Expand Down Expand Up @@ -1514,6 +1514,9 @@ stages:
```

It'll then assert that each replica received those commands, in order.

### Notes
- There is no need to change anything in the replica implementation for this stage.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"There is no need" is a bit unclear and vague - first question a person would ask is "why is there no need?"

Can't think of a clean neat sentence to improve off the top of my head - @andy1li do you want to come up with a few options here? Also worth looking at our other stage instructions to see if we already have something similar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Options:

  • No changes are needed in the replica implementation for this stage. You’ll handle that in the upcoming stages.
  • For this stage, focus only on the master. Changes to the replica will be covered in the upcoming stages.
  • This stage doesn’t require any changes to the replica implementation. You’ll handle that soon.

Existing instructions:

https://app.codecrafters.io/courses/interpreter/stages/xc5:

In this stage, you'll add support for scanning other single-character tokens, namely ,, ., -, +, ; and *. / is not covered here, it's covered in later stages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted to just adding "master" to the hook.

marketing_md: |
In this stage, you'll complete your implementation of Redis replication.

Expand Down
Loading