Skip to content

Conversation

@mmazanec22
Copy link
Contributor

Link to pivotal/JIRA issue

https://github.com/newjersey/affordability-pm/issues/366

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

What was done?

The dependents health insurance question was not correct before. It should instead concern the current year and be shown to anyone with dependents.

How to test?

  • Pick any profile with dependents (e.g. O Neal Walker)
  • Navigate past the college exemption question to the dependents health insurance question
  • Check one of the boxes
  • Check the PDF and XML

Screenshots (for visual changes)

Copy was updated
image

@jachan jachan self-assigned this Sep 26, 2025
@github-actions
Copy link

Heroku app: https://gyr-review-app-6071-b6aa60566c7f.herokuapp.com/
View logs: heroku logs --app gyr-review-app-6071 (optionally add --tail)

it "does not show" do
it "shows" do
allow_any_instance_of(StateFileNjIntake).to receive(:has_health_insurance_requirement_exception?).and_return(false)
allow_any_instance_of(StateFileNjIntake).to receive(:eligibility_all_members_health_insurance_no?).and_return(false)
Copy link
Contributor

@mluedke2 mluedke2 Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[dust] - I think these two lines could optionally be removed now like they are for the no dependents scenario above, right?

allow_any_instance_of(StateFileNjIntake).to receive(:has_health_insurance_requirement_exception?).and_return(false)
allow_any_instance_of(StateFileNjIntake).to receive(:eligibility_all_members_health_insurance_no?).and_return(false)

@mluedke2
Copy link
Contributor

I don't understand how the question could have been incorrect before -- it's still 2025 so how can we ask people about this year when tax filing for 2025 hasn't started yet? Were we supposed to ask back in January 2025 about the first few weeks of the year already? Put another way, I've never seen present tense in a tax filing question so that confuses me.

Is it because getting an extension this late into the year actually changes the rules and people are now asked about this year as well?

All that being said, I'm presuming the answer is just that I don't know this corner of the tax filing world and all is well... and given all that, from a technical standpoint I'm a 👍

@mmazanec22
Copy link
Contributor Author

@mluedke2 Apparently the only reason taxation includes this question is to share this data with an outreach team. They care about whether or not your dependents currently have health insurance so they can get enrolled. It does not affect the tax calculation.

@mluedke2
Copy link
Contributor

Ahhhh ok. That makes way more sense. Thanks!

@emtwelp
Copy link

emtwelp commented Sep 29, 2025

Just tested, and this looks good to me!

@mmazanec22 mmazanec22 merged commit 41c522a into main Sep 29, 2025
8 checks passed
@mmazanec22 mmazanec22 deleted the nj-366-dep-health-ins branch September 29, 2025 20:39
tahsinaislam pushed a commit that referenced this pull request Oct 15, 2025
Change logic to show NJ health insurance question to anyone with dependents, update copy to current year
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants