GYR1-851 Update income amount for new tax year #6127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-6127-a9c184031b60.herokuapp.com/ |
mpidcock
approved these changes
Dec 4, 2025
Member
mpidcock
left a comment
mpidcock
left a comment
There was a problem hiding this comment.
Fine for now, but something to consider for later
Comment on lines
2219
to
+2224
| 12500_to_25000: "$15,000 - 30,000" | ||
| 1_to_12500: "$1 - $15,000" | ||
| 25000_to_40000: "$30,000 - 45,000" | ||
| 40000_to_66000: "$45,000 - 67,000" | ||
| 66000_to_79000: "$67,000 - 84,000" | ||
| over_79000: over $84,000 | ||
| 40000_to_66000: "$45,000 - 69,000" | ||
| 66000_to_79000: "$69,000 - 89,000" | ||
| over_79000: over $89,000 |
Member
There was a problem hiding this comment.
I'm not sure where to write this down, but when we more fully revisit the income ranges, would it make sense to use (something like) range_1, range_2 ... upper_limit instead of having the amounts in the key? cc @embarnard if you have thoughts. I think there are other places this happens also.
Contributor
Author
There was a problem hiding this comment.
Maybe for the follow up story for this?
tahsinaislam
deleted the
GYR1-851-update-income-amounts-for-the-new-tax-year
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required?
What was done?