Skip to content

GYR1-894 Update offseason banner copy #6158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tahsinaislam merged 3 commits into from
Jan 20, 2026
Merged

GYR1-894 Update offseason banner copy #6158

tahsinaislam merged 3 commits into from
Jan 20, 2026

Conversation

@tahsinaislam
Copy link
Contributor

@tahsinaislam tahsinaislam commented Jan 16, 2026 •
edited
Loading

Link to pivotal/JIRA issue

Is PM acceptance required?

  • Yes - don't merge until JIRA issue is accepted!

What was done?

  • Updated logic so that the filing years are updated for end of login instead of start of the season
  • End of login is calculated by going back 3 months from the start of season as last year's end of login config does not exist

How to test?

  • Updated unit tests to reflect new logic

Screenshots (for visual changes)

  • Before
Screenshot 2026-01-16 at 5 24 03 PM Screenshot 2026-01-16 at 5 18 30 PM
  • After
Screenshot 2026-01-16 at 5 23 45 PM Screenshot 2026-01-16 at 5 18 46 PM

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Heroku app: https://gyr-review-app-6158-5cb284592aed.herokuapp.com/
View logs: heroku logs --app gyr-review-app-6158 (optionally add --tail)

@tahsinaislam tahsinaislam merged commit 7b77e5b into main Jan 20, 2026
8 checks passed
@tahsinaislam tahsinaislam deleted the GYR1-894-update-the-date-in-off-season-copy branch January 20, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpidcock mpidcock mpidcock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tahsinaislam @mpidcock