-
Notifications
You must be signed in to change notification settings - Fork 0
WRSAT-188 Create School Screen #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
anisharamnani
commented
Jan 15, 2026

| } No newline at end of file | ||
| } | ||
|
|
||
| .notice { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, so this affects the styling of all notices, which includes the one on the landing page that is white which we don't want to change. could you put these styles in a different class and apply it to the various places where we have these? you could do a similar thing to the notice on the landing page (line 29 of this file) and do .notice.teal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! that is a good idea & good call. next time i’ll do this i won’t assume that a style is being used in one place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test is fine to leave as is but for future reference we probably don't need to test every possible param value imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya that is fair…hmm…maybe i will just remove it then.
jenny-heath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only blocking comment is the styling thing!