fix(readonly): prevent warning on initial read-only mode toggle #2969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akulistus
requested review from
TatianaFomina,
gohabereg,
ilyamore88 and
neSpecc
as code owners
neSpecc
reviewed
Dec 29, 2025
src/components/modules/readonly.ts
Outdated
| this.readOnlyEnabled = state; | ||
|
|
||
| /** | ||
| * Do not render UI if state is read-only and it's initial call |
Member
There was a problem hiding this comment.
what does it mean "do not render UI" ? please, update jsdoc to make it more straightforward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
If
readOnlyis initially set totrue, Console tab displays warning:EventDispatcher .off(): there is no subscribers for event "editor mobile layout toggled". Probably, .off() called before .on().Issue:
#2772
Solution:
Add a guard to prevent unsubscribing from an event that was never subscribed when initial read-only mode is set to
true.