Skip to content

fix(readonly): prevent warning on initial read-only mode toggle #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akulistus wants to merge 2 commits into
base: next
Choose a base branch
from
Open

fix(readonly): prevent warning on initial read-only mode toggle #2969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdac5db
fix(readonly): prevent warning on initial read-only mode toggle
akulistus Dec 29, 2025
c95d16b
fix(blockSettings): prevent warning on initial read-only mode toggle
akulistus Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@editorjs/editorjs",
"version": "2.31.0",
"version": "2.31.1",
"description": "Editor.js — open source block-style WYSIWYG editor with JSON output",
"main": "dist/editorjs.umd.js",
"module": "dist/editorjs.mjs",
Expand Down
8 changes: 7 additions & 1 deletion src/components/modules/toolbar/blockSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,13 @@ export default class BlockSettings extends Module<BlockSettingsNodes> {
public destroy(): void {
this.removeAllNodes();
this.listeners.destroy();
this.eventsDispatcher.off(EditorMobileLayoutToggled, this.close);

/**
* Do not unsubscribe the callback if it was never subscribed
*/
if (this.nodes.wrapper) {
this.eventsDispatcher.off(EditorMobileLayoutToggled, this.close);
}
}

/**
Expand Down
Loading