Make Redis connection arguments in repr optional#664
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves the Redis health check's __repr__ method to handle cases where connection arguments (host, db) may not be present in the connection_kwargs dictionary.
Changes:
- Modified
__repr__implementation to iterate over connection_kwargs and filter for host/db keys instead of directly accessing them - Removed KeyError from exception handling since the new filtering approach eliminates that possibility
- Updated test assertions to reflect the new repr format with properly quoted string values
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| health_check/contrib/redis.py | Changed repr implementation to filter connection_kwargs for host/db keys, making these parameters optional |
| tests/contrib/test_redis.py | Updated test assertions to match new repr format with quoted host values |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
===========================================
- Coverage 100.00% 99.73% -0.27%
===========================================
Files 13 13
Lines 765 763 -2
===========================================
- Hits 765 761 -4
- Misses 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #659