Skip to content

Fix packaging deprecation and flake8 regression in tests - #156

Merged
cottsay merged 3 commits into
colcon:masterfrom
MatthijsBurgh:small_fixes
Jan 26, 2026
Merged

Fix packaging deprecation and flake8 regression in tests#156
cottsay merged 3 commits into
colcon:masterfrom
MatthijsBurgh:small_fixes

Conversation

@MatthijsBurgh

Copy link
Copy Markdown
Contributor

No description provided.

@MatthijsBurgh

Copy link
Copy Markdown
Contributor Author

@cottsay Happy new year. Please review this PR.

@christophebedard christophebedard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I have permissions on this repo, but here's a ✔️ anyway

@MatthijsBurgh

MatthijsBurgh commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

@christophebedard @cottsay please approve the workflow

@codecov-commenter

codecov-commenter commented Jan 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.74%. Comparing base (921fe5c) to head (2ebe0a9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   54.74%   54.74%           
=======================================
  Files          10       10           
  Lines         780      780           
  Branches      172      163    -9     
=======================================
  Hits          427      427           
- Misses        306      307    +1     
+ Partials       47       46    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread test/test_parse_cmake_version.py
@cottsay
cottsay merged commit d378d0f into colcon:master Jan 26, 2026
23 of 44 checks passed
@MatthijsBurgh
MatthijsBurgh deleted the small_fixes branch January 27, 2026 09:18
@cottsay cottsay changed the title Fix flake8 warning Fix packaging deprecation and flake8 regression in tests Jun 16, 2026
@cottsay cottsay added this to the 0.2.30 milestone Jun 16, 2026
@cottsay cottsay added the bug Something isn't working label Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants