Several bookkeeping changes to align with other colcon packages#167
Merged
Conversation
This variable is not assigned to, and so the scope qualifier is not necessary and may be misleading.
While this may have been well-intended, years of builds have demonstrated that we only really see deprecation warnings in our dependencies and rarely catch anything in colcon packages. We may elect to re-enable this flag in our CI builds, but having it enabled in the package itself only makes it more difficult to maintain colcon packages downstream.
We continue to see interference between the deb packages we publish from the colcon project and efforts to package colcon as part of mainline Debian and Ubuntu. Using a high Debian-Version value mitigated the problems in most cases, but was not sufficient to eliminate all of the conflicts we're currently experiencing. Using a debian version suffix which falls late alphabetically appears to give our packages preference by apt. If a user enables a repository which distributes packages created by the colcon project, it is likely that they wish to use these packages instead of the ones packaged by their platform.
Ubuntu Resolute (26.04) is the next LTS release of Ubuntu.
cottsay
force-pushed
the
cottsay/bookkeeping
branch
from
ce36f4e to
2fed012
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 15.95% 15.95%
=======================================
Files 20 20
Lines 652 652
Branches 131 114 -17
=======================================
Hits 104 104
Misses 540 540
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.