Contents verification for save_monocle_objects #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddyduran
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds safety around save_monocle_objects() by writing outputs to a temporary staging directory, repeatedly verifying file checksums for stability, and atomically swapping the final directory with rollback protection; new stability_attempts/stability_sleep parameters cover the retry behavior in io.R. New helpers wait_for_monocle_object_stability() and move_monocle_save_directory() support the checksum retry and atomic move flow. Test fixtures for save/load (monocle_objects.01.tar, transform_models.01.tar) and UMAP expectations in test-io.R are refreshed to match the stabilized outputs. Repository instructions for Codex are documented in AGENTS.md.