Conversation
…not supported by poselib
lpanaf
changed the title
ahojnnes
reviewed
Mar 13, 2025
| } | ||
| // Reset the camera to be the pinhole camera with original focal | ||
| // length and zero principal point | ||
| camera_poselib1 = poselib::Camera("SIMPLE_PINHOLE", |
Contributor
There was a problem hiding this comment.
It will be better to use "PINHOLE" and support separate focal length for x and y here?
ahojnnes
approved these changes
Mar 13, 2025
uptycs-rmack
pushed a commit
to uptycs-rmack/glomap
that referenced
this pull request
Jan 1, 2026
* fix the bug that relative pose estimation fails when camera model is not supported by poselib * allow the focal length to be different for unrecognized camera type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the bug that relative pose estimation fails when camera model is not supported by poselib