Skip to content

fix: always have title bar in dash pane one#515

Closed
greatgitsby wants to merge 1 commit intocommaai:masterfrom
greatgitsby:fix/title-bar
Closed

fix: always have title bar in dash pane one#515
greatgitsby wants to merge 1 commit intocommaai:masterfrom
greatgitsby:fix/title-bar

Conversation

@greatgitsby
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2025

Changes:

path lines diff
./pages/dashboard/Dashboard.tsx 172 +13
./pages/dashboard/activities/DeviceActivity.tsx 167 -13

Total lines: 4594 (0)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2025

deployed preview: https://515.connect-d5y.pages.dev

Welcome to connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

@greatgitsby greatgitsby marked this pull request as ready for review April 7, 2025 00:09
@incognitojam incognitojam added the bugfix fixes an issue label Apr 8, 2025
Copy link
Copy Markdown
Collaborator

@incognitojam incognitojam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now there is no button to open the drawer on mobile, if you don't have any devices - the drawer with a button to pair a device is only visible on larger screens

I guess this will also be improved with #372 and #462 but maybe we should get one of those in first?

@greatgitsby
Copy link
Copy Markdown
Contributor Author

commaai/connect#517 makes this redundant, i will close this PR

@greatgitsby greatgitsby closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix fixes an issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Title bar says No device when loading connect

2 participants