Skip to content

feat: enable audio playback for dashboard route clips#616

Closed
Mahdi451 wants to merge 5 commits intocommaai:masterfrom
Mahdi451:fix-dashboard-clip-audio
Closed

feat: enable audio playback for dashboard route clips#616
Mahdi451 wants to merge 5 commits intocommaai:masterfrom
Mahdi451:fix-dashboard-clip-audio

Conversation

@Mahdi451
Copy link
Copy Markdown

Summary

  • add an explicit mute/unmute control to the dashboard route video player
  • keep autoplay browser-safe by starting clips muted and re-muting on route changes
  • add a browser test covering the unmute flow

Problem

Dashboard route clips in new-connect always played muted because the player hard-coded the HTML5 muted attribute and provided no way for the user to reverse it.

Fix

  • move mute into local player state instead of a permanent attribute
  • add a speaker toggle to the existing overlay controls
  • preserve autoplay compatibility by keeping initial playback muted
  • catch interrupted play() promises to avoid noisy abort errors during route switches and tests

Testing

  • bun run test src/App.browser.test.tsx --run
  • manual local check at http://localhost:3000/
  • verified the clip starts muted, unmute enables audio, and route changes start muted again

Closes #615

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026

Changes:

path lines diff
./map/geocode.spec.ts 134 +105
./components/RouteVideoPlayer.tsx 214 +26
./map/geocode.live.spec.ts 18 +18
./App.browser.test.tsx 44 +4

Total lines: 4891 (+153)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026

deployed preview: https://616.connect-d5y.pages.dev

Welcome to connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

@Mahdi451
Copy link
Copy Markdown
Author

The failing test check does not appear to be caused by this audio PR.

Evidence:

  • the PR only changes RouteVideoPlayer.tsx, Icon.tsx, and App.browser.test.tsx
  • the new browser test in src/App.browser.test.tsx passed in CI
  • the failing test is src/map/geocode.spec.ts, which hits live reverse-geocoding data and is unrelated to the dashboard video player

Locally:

  • bun run test src/App.browser.test.tsx --run passes
  • bun run test src/map/geocode.spec.ts --run fails independently

This looks like a separate flaky or externally dependent geocoding test issue rather than a regression from the audio change.

@Mahdi451
Copy link
Copy Markdown
Author

Following up on the earlier unrelated CI failure mentioned here: that issue was addressed separately in #617.

That follow-up PR stabilizes the geocode tests and also fixes the GitHub Actions test job timeout/cancel behavior that was causing confusing red checks outside the audio change itself.

@Mahdi451 Mahdi451 changed the title Enable audio playback for dashboard route clips feat: enable audio playback for dashboard route clips Mar 17, 2026
@Mahdi451
Copy link
Copy Markdown
Author

Pausing this PR for now so the geocode/test stabilization can be reviewed and merged separately in #617. Once #617 lands, I'll clean this branch back down to the audio-only change and resume review here.

@Mahdi451 Mahdi451 marked this pull request as draft March 17, 2026 23:48
@Mahdi451
Copy link
Copy Markdown
Author

Closing this in favor of the fork-owned integration PR: Mahdi451#1 . The combined branch includes the route audio work plus the fork preview changes that will be validated in that preview.

@Mahdi451 Mahdi451 closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable audio playback for dashboard video clips in new dashboard player

1 participant