fix: make sign-in button keyboard accessible#619
Open
salmanshaik67 wants to merge 2 commits intocommaai:masterfrom
Open
fix: make sign-in button keyboard accessible#619salmanshaik67 wants to merge 2 commits intocommaai:masterfrom
salmanshaik67 wants to merge 2 commits intocommaai:masterfrom
Conversation
Changes:
Total lines: 4746 (+8) |
deployed preview: https://619.connect-d5y.pages.devWelcome to connect! Make sure to:
Mobile
Desktop
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The sign-in button was not keyboard accessible - pressing Tab to focus it and then Enter/Space did nothing.
Why
The element triggering Google OAuth was not a native
<button>, so browsers don't fire click events on Enter/Space keypress. Changed to a proper<button type="button">element.How I tested
Fixes New date headings are too small #551