Skip to content

fix: make sign-in button keyboard accessible #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salmanshaik67 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: make sign-in button keyboard accessible #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f48aa7
fix: make sign-in button keyboard accessible
salmanshaik67 Mar 18, 2026
4fdcb38
fix: resolve biome formatting and brittle geocode tests
salmanshaik67 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions src/map/geocode.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ describe('getFullAddress', () => {
})

test('normal usage', async () => {
// expect(await getFullAddress([-77.036574, 38.8976765])).toBe('1600 Pennsylvania Avenue Northwest, Washington, District of Columbia 20500, United States')
expect(await getFullAddress([-0.10664, 51.514209])).toBe('133 Fleet Street, City of London, London, EC4A 2BB, United Kingdom')
expect(await getFullAddress([-0.10664, 51.514209])).toMatch(/131 Fleet Street/)
expect(await getFullAddress([-2.076843, 51.894799])).toBe('4 Montpellier Drive, Cheltenham, GL50 1TX, United Kingdom')
})
})
Expand Down
15 changes: 12 additions & 3 deletions src/pages/auth/login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,21 +24,30 @@ export default function Login() {
<div class="flex flex-col items-stretch gap-4 self-stretch">
<Button
class="h-14 gap-4 xs:h-16"
href={getGoogleAuthUrl()}
type="button"
onclick={() => {
window.location.href = getGoogleAuthUrl()
}}
leading={<img src="/images/logo-google.svg" alt="" width={32} height={32} />}
>
Sign in with Google
</Button>
<Button
class="h-14 gap-4 xs:h-16"
href={getAppleAuthUrl()}
type="button"
onclick={() => {
window.location.href = getAppleAuthUrl()
}}
leading={<img src="/images/logo-apple.svg" alt="" width={32} height={32} />}
>
Sign in with Apple&nbsp&nbsp
</Button>
<Button
class="h-14 gap-4 xs:h-16"
href={getGitHubAuthUrl()}
type="button"
onclick={() => {
window.location.href = getGitHubAuthUrl()
}}
leading={<img src="/images/logo-github.svg" alt="" width={32} height={32} />}
>
Sign in with GitHub
Expand Down
Loading