Skip to content

subaru: LKAS_ANGLE support#1781

Closed
fredyshox wants to merge 31 commits intomasterfrom
subaru-angle-commahack
Closed

subaru: LKAS_ANGLE support#1781
fredyshox wants to merge 31 commits intomasterfrom
subaru-angle-commahack

Conversation

@fredyshox
Copy link
Copy Markdown
Contributor

@fredyshox fredyshox commented Feb 22, 2025

Harness: Subaru c

Checklist:

  • ES_LKAS_Angle support
  • ES_CruiseControl message for cruise_activated
  • integrate new msgs carstate
  • panda safety model
  • 100% test converage
  • pass safety_replay
  • pass test_car_model / test_car_interfaces
  • reasonable angle limits
  • investigate occasional faults on 90 turns
  • fix shaky wheel at low speed / tune
  • Gen2 angle
  • Angle + long

routes:

  • 08e4c2a99df165b1/00000045--47d798b8be stock lkas + acc
    • includes the system disengaging and 'keep hands on wheel' alerts
  • 08e4c2a99df165b1/0000001c--e76886ecd1 stock with overrides
  • 08e4c2a99df165b1/00000047--6134d3610a on this branch, faults on override

Subaru angle cars:

  • Forester 2022-2024
  • Outback 2023 (gen2)
  • Ascent 2023 (gen2)
  • Crosstrek 2024 (higher trims)?

Previous attempts:
commaai/panda#1533
#1234

@github-actions github-actions bot added car related to opendbc/car/ subaru car safety vehicle-specific safety code labels Feb 22, 2025
@fredyshox fredyshox force-pushed the subaru-angle-commahack branch from b5774cf to 211883a Compare February 22, 2025 07:33
@fredyshox fredyshox force-pushed the subaru-angle-commahack branch from c5ec72e to 2281bed Compare February 24, 2025 00:10
@github-actions
Copy link
Copy Markdown
Contributor

This PR has had no activity for 60 days. It will be automatically closed in 7 days if there is no activity.

@github-actions github-actions bot added the stale label Apr 26, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 3, 2025

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this May 3, 2025
@fredyshox fredyshox reopened this May 3, 2025
@github-actions github-actions bot removed the stale label May 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 4, 2025

This PR has had no activity for 60 days. It will be automatically closed in 7 days if there is no activity.

@github-actions github-actions bot added the stale label Jul 4, 2025
@adeebshihadeh adeebshihadeh marked this pull request as draft July 4, 2025 17:02
@adeebshihadeh adeebshihadeh deleted the subaru-angle-commahack branch February 8, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car safety vehicle-specific safety code car related to opendbc/car/ DBC signals stale subaru

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants