Replace git submodules with Python package dependencies#37302
Closed
adeebshihadeh wants to merge 6 commits intomasterfrom
Closed
Replace git submodules with Python package dependencies#37302adeebshihadeh wants to merge 6 commits intomasterfrom
adeebshihadeh wants to merge 6 commits intomasterfrom
Conversation
adeebshihadeh
force-pushed
the
fix_packages
branch
12 times, most recently
from
8312f0d to
6f6e40c
Compare
Convert teleoprtc, panda, opendbc, rednose, and msgq from git submodules/symlinks to git URL dependencies in pyproject.toml. Inline msgq and rednose SCons build logic into the top-level SConstruct, and source opendbc DBC generation from the installed package path. Remove panda firmware SConscript call. Clean up tool config exclusions and CI references for removed submodule dirs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
adeebshihadeh
force-pushed
the
fix_packages
branch
from
6f6e40c to
0eff6b0
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The test failures were caused by missing torque_data files in the opendbc package, not by slow test execution. The fix in the opendbc package should resolve the failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The msgq and rednose packages now build their Cython extensions (ipc_pyx.so, visionipc_pyx.so, ekf_sym_pyx.so) during pip install via setup.py. Remove the duplicate scons builds of these extensions from SConstruct. Keep the static library builds (libmsgq.a, libvisionipc.a, ekf_sym.a) since openpilot's own C++ binaries link against them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- cereal/__init__.py: replace runtime symlink creation with a real car.capnp file (copied from opendbc). Simplify to the original straightforward schema loading code. - SConstruct: redirect all intermediate build artifacts (.os files, .a libraries) to build/ instead of polluting site-packages. - Update msgq to pick up try/except ImportError cleanup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
This PR has had no activity for 24 days. It will be automatically closed in 7 days if there is no activity. |
Contributor
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
Contributor
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.tomlSConstruct(sourcing files from installed package paths)Companion PRs
Test plan
scons -j$(nproc)compiles successfully (msgq, visionipc, rednose C++ libs + Cython extensions)python -c "import msgq; print(msgq.BASEDIR)"resolves to installed packagepython -c "import rednose; print(rednose.HELPERS_PATH)"resolves to installed packagepython -c "import opendbc; print(opendbc.DBC_PATH)"resolves to installed packagepytest selfdrive/locationd/passes (rednose filter compilation)🤖 Generated with Claude Code