feat: test for send & sync#2
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds compile-time tests for Send and Sync trait bounds on multithreaded synchronization primitives by introducing an AssertMt trait, adds a CONTRIBUTING.md file with contribution guidelines, and removes unused Display trait implementations from atomic types.
Key changes:
- Introduces
AssertMttrait to verify Send + Sync bounds on sync module types - Adds explicit unsafe Send/Sync implementations for mutex and bilock internal types
- Adds project contribution guidelines in CONTRIBUTING.md
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Defines the AssertMt trait as a compile-time assertion for Send + Sync bounds |
| src/mutex/mod.rs | Adds explicit Send/Sync implementations for mutex types and AssertMt test for Mutex |
| src/bilock/mod.rs | Adds Send/Sync implementations for Inner and AssertMt tests for BiLock, BiLockAcquire, and BiLockGuard |
| src/mutex_blocking.rs | Adds AssertMt test for blocking Mutex wrapper around std::sync::Mutex |
| src/waker_slot.rs | Adds AssertMt test for WakerSlot (futures::task::AtomicWaker) |
| src/flag.rs | Adds AssertMt test for atomic boolean Flag |
| src/event.rs | Adds AssertMt tests for Event and EventListener types |
| src/atomic/unsync.rs | Removes Display trait implementations for AtomicBool and atomic integer types |
| CONTRIBUTING.md | Adds comprehensive contribution guidelines covering development workflow and style guide |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.