-
Notifications
You must be signed in to change notification settings - Fork 7
feat: test for send & sync #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # Contributing to Synchrony | ||
|
|
||
| Thanks for your help improving the project! We are so happy to have you! :tada: | ||
|
|
||
| There are opportunities to contribute to Synchrony at any level. It doesn't matter if | ||
| you are just getting started with Rust or are the most weathered expert, we can | ||
| use your help. If you have any question about Synchrony, feel free to join [our group](https://t.me/compio_rs) in telegram. | ||
|
|
||
| This guide will walk you through the process of contributing to Synchrony on following topics: | ||
|
|
||
| - [General guidelines](#general-guidelines) | ||
| - [Develop Guide](#develop-guide) | ||
| - [Style Guide](#style-guide) | ||
| - [Contribute with issue](#contribute-with-issue) | ||
| - [Contribute with pull request](#contribute-with-pull-request) | ||
|
|
||
| ## General guidelines | ||
|
|
||
| We adhere to [Rust Code of Conduct](https://www.rust-lang.org/policies/code-of-conduct). tl;dr: **be nice**. Before making any contribution, check existing issue and pull requests to avoid duplication of effort. Also, in case of bug, try updating to the latest version of Compio and/or rust might help. | ||
|
|
||
| ### Develop Guide | ||
|
|
||
| Use nightly toolchain to develop and run `rustup update` regularly. | ||
|
|
||
| ### Style Guide | ||
|
|
||
| - Use `cargo fmt --all` with nightly toolchain to format your code (for nightly `rustfmt` features, see detail in [`rustfmt.toml`]). | ||
| - Use `cargo clippy --all` to check any style/code problem. | ||
| - Use [Angular Convention](https://github.com/angular/angular/blob/main/CONTRIBUTING.md#-commit-message-format) when making commits | ||
|
|
||
| [`rustfmt.toml`]: https://github.com/compio-rs/synchrony/blob/master/rustfmt.toml | ||
|
|
||
| ## Contribute with issue | ||
|
|
||
| If you find a bug or have a feature request, please [open an issue](https://github.com/compio-rs/synchrony/issues/new/choose) with detailed description. Issues that are lack of information or destructive will be requested for more information or closed. | ||
|
George-Miao marked this conversation as resolved.
|
||
|
|
||
| It's also helpful if you can provide the following information: | ||
|
|
||
| - A minimal reproducible example | ||
| - The version of Synchrony you are using. | ||
| - The version of Rust you are using. | ||
| - Your environment (OS, Platform, etc). | ||
|
|
||
| ## Contribute with pull request | ||
|
|
||
| We welcome any code contributions. It's always welcome and recommended to open an issue to discuss on major changes before opening a PR. And pull requests should: | ||
|
|
||
| - follow the [Style Guide](#style-guide). | ||
| - pass CI tests and style check. | ||
| - be reviewed by at least one maintainer before getting merged. | ||
| - have a description of what it does and why it is needed in PR body. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| /// Notify async tasks or threads. | ||
| pub mod sync { | ||
| pub use event_listener::{Event, EventListener}; | ||
|
|
||
| impl crate::AssertMt for Event {} | ||
| impl crate::AssertMt for EventListener {} | ||
| } | ||
| #[doc(inline)] | ||
| pub use local_event as unsync; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.