Skip to content

fix: keep main green (invariants proof references; #472 not reproducible) - #483

Merged
schickling-assistant merged 1 commit into
mainfrom
schickling-assistant/2026-09-06-int-main-green
Sep 6, 2026
Merged

fix: keep main green (invariants proof references; #472 not reproducible)#483
schickling-assistant merged 1 commit into
mainfrom
schickling-assistant/2026-09-06-int-main-green

Conversation

@schickling-assistant

Copy link
Copy Markdown
Contributor

What

tests/invariants.rs::qualified_proof_references_resolve is RED on main at d4af275. The Resource observation is state-first, atomic, and fenced row still names four tests that #411 deleted when it rewrote tests/resource_profile_supervisor_e2e.rs onto the WASIp2 providers.

Per INVARIANTS.md's own header the guarantee is sacred, the proof reference is not: the row keeps its wording and gains the tests that carry it today.

stale reference replacement
demand_observation_settlement_matrix_is_atomic_and_preserves_facts production_demand_jobs_coalesce_queue_disconnect_and_fence_generation
demand_observation_coalesces_and_fences_watermarks (same — #411 merged the three demand tests into one)
demand_observation_survives_restart_disconnect_and_denies_missing_capability (same)
observable_publication_reaches_builtin_resync_with_filter_catch_up_and_scope_isolation production_component_preserves_resync_filter_catch_up_and_scope_isolation

The row also now cites durable_admission_retains_the_256_request_boundary_without_a_runtime (its backpressure clause) and supervisor_spawns_vista_capability_and_preserves_stable_snapshot (its stable-snapshot clause), both of which already existed and were simply uncited. No row is removed, no guarantee is weakened, and every proof the row names resolves.

#472 does not reproduce and is not fixed here

#472 claims main cannot compile its lib test target because src/run.rs:6869 builds a PtyCli literal missing on_command_spawn. That field does not exist anywhere in main:

$ git log --all --oneline -S on_command_spawn
7bd0eca test(run): synchronize PTY observation fixtures

7bd0eca is the head of #482 (schickling-assistant/2026-09-06-fix-darwin-pty-observation-tests), which introduces on_command_spawn on PtyCli. It has never been on main; struct PtyCli on main has exactly bin and catalog_root. nix develop -c cargo test --no-run at d4af275 exits 0 and links every test target, including unittests src/lib.rs. #472 is being closed as not reproducible with that evidence; the real red lane on main was the invariants test above, which is the class #438/#446 describe.

Gate

  • before: cargo test --test invariants1 passed; 1 failed, invariant proof `tests/resource_profile_supervisor_e2e.rs::demand_observation_settlement_matrix_is_atomic_and_preserves_facts` does not name a declared test
  • after: cargo test --test invariants2 passed; 0 failed
  • nix build .#st2 --no-link -L (doCheck runs the cargo suite)

agent-identity: dev3.direct.omp.43sz6ujq

Posted on behalf of @schickling
field value
agent_identity dev3.direct.omp.43sz6ujq
session dev3.43sz6ujq
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.1.7
agent_runtime OMP 18.1.7
tooling_profile dotfiles@39a19af

`tests/invariants.rs::qualified_proof_references_resolve` was RED on main:
the **Resource observation is state-first, atomic, and fenced** row still
named four tests that #411 replaced when it rewrote
`tests/resource_profile_supervisor_e2e.rs` onto the WASIp2 providers.

The guarantee is unchanged; only the proof references move to the tests
that actually carry it today:

- `demand_observation_settlement_matrix_is_atomic_and_preserves_facts`,
  `demand_observation_coalesces_and_fences_watermarks` and
  `demand_observation_survives_restart_disconnect_and_denies_missing_capability`
  collapsed into
  `production_demand_jobs_coalesce_queue_disconnect_and_fence_generation`;
- `observable_publication_reaches_builtin_resync_with_filter_catch_up_and_scope_isolation`
  became `production_component_preserves_resync_filter_catch_up_and_scope_isolation`;
- the backpressure and stable-snapshot halves of the row gain
  `durable_admission_retains_the_256_request_boundary_without_a_runtime` and
  `supervisor_spawns_vista_capability_and_preserves_stable_snapshot`,
  which already existed but were not cited.

No row is dropped and no guarantee is weakened.

agent-identity: dev3.direct.omp.43sz6ujq
agent-persona: generalist
agent-supervisor: unavailable
agent-tool: OMP
agent-tool-version: 18.1.7
agent-runtime: OMP 18.1.7
tooling-profile: dotfiles@39a19af
@schickling-assistant
schickling-assistant merged commit 9e77bf7 into main Sep 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant