fix: keep main green (invariants proof references; #472 not reproducible) - #483
Merged
schickling-assistant merged 1 commit intoSep 6, 2026
Merged
Conversation
`tests/invariants.rs::qualified_proof_references_resolve` was RED on main: the **Resource observation is state-first, atomic, and fenced** row still named four tests that #411 replaced when it rewrote `tests/resource_profile_supervisor_e2e.rs` onto the WASIp2 providers. The guarantee is unchanged; only the proof references move to the tests that actually carry it today: - `demand_observation_settlement_matrix_is_atomic_and_preserves_facts`, `demand_observation_coalesces_and_fences_watermarks` and `demand_observation_survives_restart_disconnect_and_denies_missing_capability` collapsed into `production_demand_jobs_coalesce_queue_disconnect_and_fence_generation`; - `observable_publication_reaches_builtin_resync_with_filter_catch_up_and_scope_isolation` became `production_component_preserves_resync_filter_catch_up_and_scope_isolation`; - the backpressure and stable-snapshot halves of the row gain `durable_admission_retains_the_256_request_boundary_without_a_runtime` and `supervisor_spawns_vista_capability_and_preserves_stable_snapshot`, which already existed but were not cited. No row is dropped and no guarantee is weakened. agent-identity: dev3.direct.omp.43sz6ujq agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.1.7 agent-runtime: OMP 18.1.7 tooling-profile: dotfiles@39a19af
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/invariants.rs::qualified_proof_references_resolveis RED onmainatd4af275. The Resource observation is state-first, atomic, and fenced row still names four tests that #411 deleted when it rewrotetests/resource_profile_supervisor_e2e.rsonto the WASIp2 providers.Per
INVARIANTS.md's own header the guarantee is sacred, the proof reference is not: the row keeps its wording and gains the tests that carry it today.demand_observation_settlement_matrix_is_atomic_and_preserves_factsproduction_demand_jobs_coalesce_queue_disconnect_and_fence_generationdemand_observation_coalesces_and_fences_watermarksdemand_observation_survives_restart_disconnect_and_denies_missing_capabilityobservable_publication_reaches_builtin_resync_with_filter_catch_up_and_scope_isolationproduction_component_preserves_resync_filter_catch_up_and_scope_isolationThe row also now cites
durable_admission_retains_the_256_request_boundary_without_a_runtime(its backpressure clause) andsupervisor_spawns_vista_capability_and_preserves_stable_snapshot(its stable-snapshot clause), both of which already existed and were simply uncited. No row is removed, no guarantee is weakened, and every proof the row names resolves.#472 does not reproduce and is not fixed here
#472 claims
maincannot compile its lib test target becausesrc/run.rs:6869builds aPtyCliliteral missingon_command_spawn. That field does not exist anywhere inmain:7bd0ecais the head of #482 (schickling-assistant/2026-09-06-fix-darwin-pty-observation-tests), which introduceson_command_spawnonPtyCli. It has never been onmain;struct PtyClionmainhas exactlybinandcatalog_root.nix develop -c cargo test --no-runatd4af275exits 0 and links every test target, includingunittests src/lib.rs. #472 is being closed as not reproducible with that evidence; the real red lane onmainwas the invariants test above, which is the class #438/#446 describe.Gate
cargo test --test invariants→1 passed; 1 failed,invariant proof `tests/resource_profile_supervisor_e2e.rs::demand_observation_settlement_matrix_is_atomic_and_preserves_facts` does not name a declared testcargo test --test invariants→2 passed; 0 failednix build .#st2 --no-link -L(doCheck runs the cargo suite)agent-identity: dev3.direct.omp.43sz6ujq
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimetooling_profile