libsodium: conan2 compatibility with msvc

[danimtb]

A small detail to make the recipe fully compatible as the comparison if self.settings.compiler == "Visual Studio" is not allowed on conan 2 because "Visual Studio" is not among the valid values for settings

[prince-chrismc]

I assume this works because this function is never called with mac/linux compilers 🤔

[danimtb]

you are right 🙃

[SpaceIm]

I guess str(self.settings.compiler) == "Visual Studio" would also work?

[danimtb]

probably so

[SpaceIm]

there are other checks like that afterwards, so it requires more modifications in this method.

[SpaceIm]

I would replace by something like this:

    @property
    def _msvc_sln_folder(self):
        sln_folders = {
            "Visual Studio": {
                "10": "vs2010",
                "11": "vs2012",
                "12": "vs2013",
                "14": "vs2015",
                "15": "vs2017",
                "16": "vs2019",
            },
            "msvc": {
                "170": "vs2012",
                "180": "vs2013",
                "190": "vs2015",
                "191": "vs2017",
                "192": "vs2019",
            }
        }
        if self.version != "1.0.18":
            sln_folders["Visual Studio"]["17"] = "vs2022"
            sln_folders["msvc"]["193"] = "vs2022"

        backup_folder = "vs2022" if self.version != "1.0.18" else "vs2019"

        return sln_folders.get(str(self.settings.compiler), {}).get(str(self.settings.compiler.version), backup_folder)

[danimtb]

Absolutely right, I did this quickly and didn't check it further. Thank you for the code suggestion

[SpaceIm]

This recipe has many issues in its Visual Studio branch anyway since its migration to conan v2, it needs far more love or improvement in MSBuild helper from conan client.

[conan-center-bot]

Conan v1 pipeline

All green in build 6 (36cf9e6dc9a4b4b5d121d2b8d8faaf029d55bbe0):

• libsodium/cci.20220430@:
  All packages built successfully! (All logs)

• libsodium/1.0.18@:
  All packages built successfully! (All logs)

---

Conan v2 pipeline (informative, not required for merge)

Failure in build 6 (36cf9e6dc9a4b4b5d121d2b8d8faaf029d55bbe0):

• libsodium/1.0.18@:
  CI failed to create some packages (All logs)

  Logs for packageID 37528097d0726778529e8dd34f4e73ec2f157344:

  [settings]
  arch=x86_64
  build_type=Release
  compiler=apple-clang
  compiler.libcxx=libc++
  compiler.version=13
  os=Macos
  [options]
  */*:shared=False
  

  ********************************************************************************
  conan install --require=libsodium/1.0.18@#3515a4e8f2e5c1ef9f6bf4648fc71f9e --build=libsodium/1.0.18 -pr:h /Users/jenkins/w/prod-v2/BuildSingleReference/7055/1e20b378-d766-4d3b-9607-11a8cf893978/profile_osx_13_libcpp_apple-clang_release_64.-shared-False.txt -c:h tools.system.package_manager:mode=install -c:h tools.system.package_manager:sudo=True -c:h tools.apple:sdk_path=/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -pr:b /Users/jenkins/w/prod-v2/BuildSingleReference/7055/1e20b378-d766-4d3b-9607-11a8cf893978/profile_osx_13_libcpp_apple-clang_release_64.-shared-False.txt -c:b tools.system.package_manager:mode=install -c:b tools.system.package_manager:sudo=True -c:b tools.apple:sdk_path=/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk
  ********************************************************************************
  ERROR: /Users/jenkins/w/prod-v2/BuildSingleReference/extensions/plugins/profile.py not found!
  

• libsodium/cci.20220430@:
  Didn't run or was cancelled before finishing

---

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

[ghost]

I detected other pull requests that are modifying libsodium/all recipe:

• libsodium: implement better workaround for the lack of automatic interaction between MSBuildToolchain & MSBuild #15041

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[SpaceIm]

I've submitted another PR with more fixes: #14998

[danimtb]

closing this one then, as #14998 already contained this fix. Thank you!