-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
add traits #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add traits #391
Conversation
Hi! This is the friendly conda-forge-admin automated user. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
||
source: | ||
git_url: https://github.com/enthought/traits | ||
git_tag: {{ version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this available from PyPI? That would be preferred.
Made some comments. Please let me know if you have any questions. |
I have made the suggested changes |
|
||
build: | ||
number: 0 | ||
script: python setup.py install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking into it, seems this uses setuptools
. So could we please add these flags --single-version-externally-managed --record record.txt
?
Thanks. Looking pretty good. A few more comments. Also, please apply similar changes to other PRs in the works. |
okay, I will make the same changes to my other recent PRs |
Excellent. Thanks @grlee77. |
@grlee77, since this is your first time being added as a maintainer at conda-forge, I am going to explain what is about to happen. When this recipe gets merged, it will be converted to a feedstock (repo) (see here) that contains the recipe in a directory so named and some CI files used for automated build and deployment of packages to the If you have questions or concerns, feel free to let us know. Welcome to conda-forge. |
Add traits recipe as required by #285
Is it okay to set
git_tag
using {{ version }} as done here? Or should the specific commit number be used instead?