Skip to content

add traits #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2016
Merged

add traits #391

merged 4 commits into from
Apr 18, 2016

Conversation

grlee77
Copy link
Member

@grlee77 grlee77 commented Apr 18, 2016

Add traits recipe as required by #285

Is it okay to set git_tag using {{ version }} as done here? Or should the specific commit number be used instead?

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge-admin automated user.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/traits) and found it was in an excellent condition.


source:
git_url: https://github.com/enthought/traits
git_tag: {{ version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this available from PyPI? That would be preferred.

@jakirkham
Copy link
Member

Made some comments. Please let me know if you have any questions.

@grlee77
Copy link
Member Author

grlee77 commented Apr 18, 2016

I have made the suggested changes


build:
number: 0
script: python setup.py install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking into it, seems this uses setuptools. So could we please add these flags --single-version-externally-managed --record record.txt?

@jakirkham
Copy link
Member

Thanks. Looking pretty good. A few more comments. Also, please apply similar changes to other PRs in the works.

This was referenced Apr 18, 2016
@grlee77
Copy link
Member Author

grlee77 commented Apr 18, 2016

okay, I will make the same changes to my other recent PRs

@jakirkham
Copy link
Member

Excellent. Thanks @grlee77.

@jakirkham jakirkham merged commit 59b3f39 into conda-forge:master Apr 18, 2016
@jakirkham
Copy link
Member

@grlee77, since this is your first time being added as a maintainer at conda-forge, I am going to explain what is about to happen. When this recipe gets merged, it will be converted to a feedstock (repo) (see here) that contains the recipe in a directory so named and some CI files used for automated build and deployment of packages to the conda-forge channel. This will trigger its first build and release. After this happens a separate CI script will be triggered that will add this to our webpage listing of packages, add it to the feedstocks repo (like conda-recipes with git submodules), and then invite you to join conda-forge. After accepting the invite, you will be added to a team called traits. This gives you commit rights over the feedstock (repo) and control over its respective CIs. It will also automatically subscribe you to watch that feedstock (repo). In the future, simply having your GitHub handle added by yourself or by someone (with your permission) will be all that is necessary to add you to other feedstocks.

If you have questions or concerns, feel free to let us know. Welcome to conda-forge.

@grlee77 grlee77 deleted the traits branch June 3, 2016 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants