Skip to content

Conversation

@forsyth2
Copy link

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@forsyth2
Copy link
Author

@conda-forge-admin, please rerender

@forsyth2 forsyth2 mentioned this pull request Oct 16, 2025
7 tasks
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18576500435. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18576511626. Examine the logs at this URL for more detail.

@forsyth2
Copy link
Author

@andrewdnolan @xylar This PR is ready for review.

It's a pretty minimal update for zstash, adding just two PRs, neither of which are particularly user-facing:

@xylar
Copy link
Contributor

xylar commented Oct 17, 2025

@forsyth2, could you explain to me why this release candidate is needed? It seems like there are no meaningful code changes since rc1.

@xylar
Copy link
Contributor

xylar commented Oct 17, 2025

It's a pretty minimal update for zstash, adding just two PRs, neither of which are particularly user-facing

I see, missed this. I would go further to say that no changes since the last RC have any impact on the package itself and aren't worth the time of making a RC. Let's focus RCs only on code changes that need testing.

@forsyth2
Copy link
Author

could you explain to me why this release candidate is needed?

I suppose it's not strictly needed. I just figured I might as well include the latest change if we're making rc2 anyway. If it just creates more work, we can drop it.

@xylar
Copy link
Contributor

xylar commented Oct 17, 2025

Yes, I would put this in the category of needless work, especially for you. Let's drop it.

@xylar xylar closed this Oct 17, 2025
@forsyth2 forsyth2 mentioned this pull request Oct 18, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants