e2e: run tdx operator tests on ubuntu-24.04 runner #535
Conversation
kata-deploy supports Ubuntu 24.04 (and 25.04) based TDX enablement. Since the operator e2e does not test any TEE specifics, it's enough to test that kata-qemu-tdx runtimeclass gets created on a vanilla Ubuntu 24.04. Signed-off-by: Mikko Ylinen <[email protected]>
|
It seems this cannot be tested because of |
one option is to just get it merged and see the nightly results. @confidential-containers/operator-maintainers WDYT? |
|
I think this is fine for now, but we discussed the idea of doing use cases scenarios in the operator e2e testing a long time ago to add more tests and the standard runner wouldn't work for that. However I'm not sure anyone has bandwidth/plans to add this testing, so maybe it's a problem for a future day? |
|
Right, I believe #446 was one of those e2e use cases. I closed it last week since I don't think it's going to get finished and it's been on hold for about a year now. If TEE based tests are added, I can revisit this change but as it is now, we won't loose any coverage for TDX. |
stevenhorsman
left a comment
stevenhorsman
left a comment
There was a problem hiding this comment.
Seems reasonable to me based on our current e2e test coverage
|
@ldoktor mind checking this? |
ldoktor
left a comment
ldoktor
left a comment
There was a problem hiding this comment.
Makes sense to me and should work as long as we don't introduce functional test.
I like the instance/exclude removal replaced with include only. We should do that for sev-snp as well (only the exclude part, not the change of the instance type itself)
|
will monitor nightly-e2e results for tdx and act if needed. |
|
Sure, hopefully it'll work well. I was running local testing and it failed, but could have been just timeout issue. I'll try again. |
|
Cool, the second run worked well (on my ubuntu vm) |
3 participants
kata-deploy supports Ubuntu 24.04 (and 25.04) based TDX enablement. Since the operator e2e does not test any TEE specifics, it's enough to test that kata-qemu-tdx runtimeclass gets created on a vanilla Ubuntu 24.04.