fix(idempotency): make kafka-storage command return correct changed_when status #2383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets
changed_whenfor thekafka-storage formatcommand based on the output from the command. This will avoid false positives when nothing is changed.PS: This is a reimplementation of #1895 for the current development branch. (You implemented part of my original PR in #2181)
Type of change
How Has This Been Tested?
Tested in our local provisioning pipeline.
Checklist:
For local testing of the
changed_whenlogic, you may use the playbook here: https://github.com/sverrehu/ansible-tests/tree/master/kafka-storage-formatYou will need to change the
binary_base_pathinplaybook.ymlto point to your Kafka command-line installation.