Friday version of React Cinema #9
Conversation
.gitignore
Outdated
| /node_modules | ||
| /dist | ||
| .DS_Store | ||
| /images |
There was a problem hiding this comment.
I expect images should be included in repo otherwise someone looking at your repo will not have access to them
src/components/App.js
Outdated
| receiveInput (text) { | ||
| this.setState({ | ||
| searchQuery: text, | ||
| searchDisplay: text.length > 0 |
There was a problem hiding this comment.
Rather than storing searchDisplay in state, it might be better to compute it in the render method as it's a derived property which depends on the searchQuery value.
src/components/App.js
Outdated
|
|
||
| // receive focus event from Search component | ||
| receiveFocus () { | ||
| this.setState({ searchDisplay: this.state.searchQuery.length > 0}) |
There was a problem hiding this comment.
If searchDisplay is computed in render method, we can set a focused property in state here
src/components/LocalStorage-v2.js
Outdated
| @@ -0,0 +1,82 @@ | |||
| // http://www.omdbapi.com/?s=batman&apikey=2cda7206 | |||
There was a problem hiding this comment.
It looks like this file is not in use and can go into .gitignore
|
|
||
| render () { | ||
| return ( | ||
| <div dangerouslySetInnerHTML={{__html: this.props.children}}> |
There was a problem hiding this comment.
This seems unnecessary. It looks like this is only used to wrap the h3 in a div. Why not do it directly in MovieDisplay component?
|
Really nice work |
Changes for deployment
Webpack bugs now fixed
Updated API URL - removed http: due to mixed content error
Heruko deployment
Updated webpack with CleanWebpackPlugin
2 participants
No description provided.