Skip to content

Friday version of React Cinema #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rolandjlevy wants to merge 61 commits into
base: master
Choose a base branch
from
Open

Friday version of React Cinema #9

Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
7ab5fa9
first stage - fetching from API based on search query
rolandjlevy Sep 28, 2018
31605bd
Receiving results from fetch. trying to create results as a menu of l…
rolandjlevy Sep 28, 2018
6c86781
search results appearing in a list. Bug with errors though
rolandjlevy Sep 28, 2018
3cade8a
Bug fixed
rolandjlevy Sep 28, 2018
da704af
started to display selected movie
rolandjlevy Sep 29, 2018
36d24d8
Fixed bugs and added some styling
rolandjlevy Sep 29, 2018
1e0f80f
mobile view complete. NO working on responsiveness for iPad and Deskt…
rolandjlevy Sep 29, 2018
f77e57f
Minor tweaks
rolandjlevy Sep 29, 2018
739612e
Added pagination
rolandjlevy Sep 29, 2018
da7af7a
fixing bugs
rolandjlevy Sep 29, 2018
aa6c697
Completed pagination
rolandjlevy Sep 30, 2018
28f4625
Fixed bug with pagination
rolandjlevy Sep 30, 2018
ef54af3
Bug in DisplayMovie.js not rendering HTML correctly
rolandjlevy Sep 30, 2018
5aefa2b
fixed HTML render bug by making a component that uses dangerouslySetI…
rolandjlevy Sep 30, 2018
10c6335
Working on layout for iPad and desktop
rolandjlevy Sep 30, 2018
16485ae
Working on responsiveness
rolandjlevy Sep 30, 2018
6ac7740
made a start on favourites but ran out of time
rolandjlevy Sep 30, 2018
1584ebd
Updated favourites. Still no working.
rolandjlevy Sep 30, 2018
aa3039f
Tweaked CSS
rolandjlevy Oct 1, 2018
b2ac6b1
CSS tweaks
rolandjlevy Oct 1, 2018
901c42a
Added more commenting
rolandjlevy Oct 2, 2018
a7a64c5
Improved code in App.js by changing the way searchDisplay is set and …
rolandjlevy Oct 3, 2018
43fb8de
Completed Readme file
rolandjlevy Oct 10, 2018
785ae17
Small changes to Readme text
rolandjlevy Oct 10, 2018
8f9b70f
Updated Readme file
rolandjlevy Oct 16, 2018
ba79bad
Updated readme
rolandjlevy Nov 30, 2018
6a4fe9a
Readme updated
rolandjlevy Nov 30, 2018
60a1d00
Updated readme
rolandjlevy Nov 30, 2018
d4e25d7
Updated readme
rolandjlevy Nov 30, 2018
43dce84
Set theme jekyll-theme-minimal
rolandjlevy Dec 2, 2018
d94f276
Set theme jekyll-theme-minimal
rolandjlevy Dec 2, 2018
fd20642
Delete _config.yml
rolandjlevy Dec 2, 2018
269ad07
Update README.md
rolandjlevy Dec 2, 2018
5316fac
Changed where and how baseUrl is defined so Netlify can access it as …
rolandjlevy Dec 2, 2018
022b015
.env variablees not working
rolandjlevy Dec 2, 2018
15af6ae
Temporary fix for API_KEY bug in .env file
rolandjlevy Dec 2, 2018
3ce26e6
Resolved problem with API_KEY loading from .env file
rolandjlevy Dec 3, 2018
56dd76c
Updated readme
rolandjlevy Dec 3, 2018
b14affa
Updated readme
rolandjlevy Dec 3, 2018
25e42c5
Updated readme
rolandjlevy Dec 3, 2018
9ec7c17
Updated for Heroku deployment
rolandjlevy Dec 3, 2018
b970c5a
Updated package.json
rolandjlevy Dec 4, 2018
4c0c7ea
Updated webpack
rolandjlevy Dec 4, 2018
65c3ee1
Updated package.json by removing commented out link at the start of t…
rolandjlevy Dec 4, 2018
bbba912
Changes for deployment
rolandjlevy Dec 4, 2018
8005dcc
Merge pull request #1 from rolandjlevy/heruko-deployment
rolandjlevy Dec 4, 2018
52f10d5
Webpack bugs now fixed
rolandjlevy Dec 5, 2018
e7eb5c9
Merge pull request #2 from rolandjlevy/heruko-deployment
rolandjlevy Dec 5, 2018
77a4e3d
Updated API URL - removed http: due to mixed content error
rolandjlevy Dec 5, 2018
a26ed41
Merge pull request #3 from rolandjlevy/heruko-deployment
rolandjlevy Dec 5, 2018
5ca0b22
Updated readme
rolandjlevy Dec 5, 2018
75bf2aa
Updated readme
rolandjlevy Dec 5, 2018
5c3fa6c
Merge pull request #4 from rolandjlevy/heruko-deployment
rolandjlevy Dec 5, 2018
bd1e886
Updated webpack with CleanWebpackPlugin
rolandjlevy Dec 5, 2018
3fada5f
Merge pull request #5 from rolandjlevy/heruko-deployment
rolandjlevy Dec 5, 2018
acd15c7
Tweaked code for deployment
rolandjlevy Dec 5, 2018
d4cae81
Merge branch 'parcel-james'
rolandjlevy Dec 5, 2018
c652020
turned on ts in vscode
rolandjlevy Dec 5, 2018
d7189e2
Updated readme
rolandjlevy Dec 20, 2018
37eb936
Updated readme
rolandjlevy Dec 20, 2018
20a9d2c
Updated readme
rolandjlevy Dec 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/node_modules
/dist
.DS_Store
/images
Copy link
Contributor

@dmitrigrabov dmitrigrabov Oct 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect images should be included in repo otherwise someone looking at your repo will not have access to them

Binary file added assets/no-image.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/popcorn-bg-pink.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/popcorn-bg-smaller-brighter.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading