Fix container export emitting incorrect event type. #27896
Merged
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shiavm006 <[email protected]>
Contributor
Author
|
@Luap99 The CI failure appears to be unrelated to this PR |
baude
reviewed
Jan 14, 2026
| result.WaitWithDefaultTimeout() | ||
| Expect(result).Should(ExitCleanly()) | ||
|
|
||
| eventsResult := podmanTest.Podman([]string{"events", "--stream=false", "--filter", "event=export", "--since", "30s"}) |
Member
There was a problem hiding this comment.
anytime i see a time based anything on our CI, I think flakes. That said, I cannot think of a better way to do this without some sort of a wait, and casting a broader event search ... then iterating in the slice for what you are looking for in lines 69-70. Not a deal breaker rn I dont think though...
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
Container.Export()method was incorrectly emitting amountevent instead of anexportevent. This breaks event filtering for users who expect to filter onexportevents as documented inpodman-events(1).Changed the event emitted by
Container.Export()fromevents.Mounttoevents.Exportto match the user-facing operation.The internal
export()function does mount the container filesystem if needed, but that is an implementation detail. The event should reflect what the user requested (export), not the internal mechanism (mount).