fix: align imagePullSecrets in Deployment and ServiceAccount #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes coredns#154 I also took the opportunity to align the `if` statements in the `Deployment` templates to what is used in the `ServiceAccount` templates. Signed-off-by: martinohmann <[email protected]>
hagaibarel
approved these changes
Feb 25, 2025
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed and what does it do?
Fixes the misalignment between the structure expected for
image.pullSecretsindeployment.yaml/deployment-autoscaler.yamlandserviceaccount.yaml/serviceaccount-autoscaler.yamlwhich made it impossible to use imagePullSecrets because they produced invalid manifests.I also took the opportunity to align the
ifstatements in theDeploymenttemplates to what is used in theServiceAccounttemplates for consistency.Which issues (if any) are related?
Fixes #154
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.Note on DCO
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.