test: ironbird fixes [DNM] #24630
test: ironbird fixes [DNM] #24630
Conversation
Ironbird - launch a networkTo use Ironbird, you can use the following commands:
Custom Load Test ConfigurationYou can provide a custom load test configuration using the `--load-test-config=` flag:Use |
|
/ironbird start simapp-v53 --load-test-config={"name":"unordered_test2","description":"unordered multisends","unordered_txs":true,"tx_timeout":"5m","num_of_txs":1000,"num_of_blocks":100,"msgs":[{"weight":1,"type":"MsgMultiSend","num_of_recipients":5}]} |
|
Ironbird has started a testnet for chain Chain detailsChain: Version: Runner: Workflow ID: Run ID: Load test detailsLoad test config: |
📝 WalkthroughWalkthroughThe change updates the startup log message in the API server code. The message now specifies "ironbird" in the log output when the server starts, instead of the previous generic message. No other code logic, control flow, or public API declarations were modified. Changes
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
server/api/server.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (16)
- GitHub Check: test-system-legacy
- GitHub Check: test-system
- GitHub Check: tests (03)
- GitHub Check: tests (02)
- GitHub Check: tests (01)
- GitHub Check: tests (00)
- GitHub Check: test-sim-nondeterminism
- GitHub Check: test-integration
- GitHub Check: test-e2e
- GitHub Check: build (arm64)
- GitHub Check: Analyze
- GitHub Check: Check up to date mocks
- GitHub Check: build (amd64)
- GitHub Check: golangci-lint
- GitHub Check: Gosec
- GitHub Check: Summary
| @@ -159,7 +159,7 @@ func (s *Server) Start(ctx context.Context, cfg config.Config) error { | |||
| // an error upon failure, which we'll send on the error channel that will be | |||
| // consumed by the for block below. | |||
| go func(enableUnsafeCORS bool) { | |||
| s.logger.Info("starting API server...", "address", cfg.API.Address) | |||
| s.logger.Info("starting ironbird API server...", "address", cfg.API.Address) | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Ensure consistent branding across all API server log messages.
The startup log now includes “ironbird”, but the stopping ("stopping API server...") and error ("failed to start API server") logs still omit it. To maintain uniformity and improve clarity, update those messages to include “ironbird” as well (consider capitalizing “Ironbird” if that’s the intended branding).
🤖 Prompt for AI Agents (early access)
In server/api/server.go at line 162, the startup log message includes "ironbird" but the stopping and error log messages do not. Update the stopping and error log messages to also include "Ironbird" with consistent capitalization to ensure uniform branding across all API server logs.
|
/ironbird start simapp-v53 --load-test-config={"name":"unordered_test2","description":"unordered multisends","unordered_txs":true,"tx_timeout":"5m","num_of_txs":1000,"num_of_blocks":100,"msgs":[{"weight":1,"type":"MsgMultiSend","num_of_recipients":5}]} |
|
Ironbird has started a testnet for chain Chain detailsChain: Version: Runner: Workflow ID: Run ID: Load test detailsLoad test config: |
|
/ironbird start simapp-v53 --load-test-config={"name":"unordered_test2","description":"unordered multisends","unordered_txs":true,"tx_timeout":"5m","num_of_txs":1500,"num_of_blocks":100,"msgs":[{"weight":1,"type":"MsgMultiSend","num_of_recipients":5}]} |
|
Ironbird has started a testnet for chain Chain detailsChain: Version: Runner: Workflow ID: Run ID: Load test detailsLoad test config: |
|
/ironbird start simapp-v53 --load-test-config={"name":"unordered_test2","description":"unordered multisends","unordered_txs":true,"tx_timeout":"5m","num_of_txs":2500,"num_of_blocks":100,"msgs":[{"weight":1,"type":"MsgMultiSend","num_of_recipients":20}]} |
|
Ironbird has started a testnet for chain Chain detailsChain: Version: Runner: Workflow ID: Run ID: Load test detailsLoad test config: |
|
/ironbird start simapp-v53 --load-test-config={"name":"unordered_test2","description":"unordered multisends","unordered_txs":"false","num_of_txs":2500,"num_of_blocks":100,"msgs":[{"weight":1,"type":"MsgMultiSend","num_of_recipients":100}]} |
|
Ironbird failed to run command |
|
/ironbird start simapp-v53 --load-test-config={"name":"unordered_test3","description":"unordered multisends","unordered_txs":true,"tx_timeout":"5m","num_of_txs":2500,"num_of_blocks":100,"msgs":[{"weight":1,"type":"MsgMultiSend","num_of_recipients":20}]} |
|
Ironbird has started a testnet for chain Chain detailsChain: Version: Runner: Workflow ID: Run ID: Load test detailsLoad test config: |
|
/ironbird start simapp-v53 --load-test-config={"name":"unordered_test2","description":"unordered multisends","unordered_txs":false,"num_of_txs":2500,"num_of_blocks":100,"msgs":[{"weight":1,"type":"MsgMultiSend","num_of_recipients":100}]} |
|
Ironbird has started a testnet for chain Chain detailsChain: Version: Runner: Workflow ID: Run ID: Load test detailsLoad test config: |
|
/ironbird start simapp-v53 --load-test-config={"name":"unordered_test5","description":"unordered multisends","unordered_txs":false,"num_of_txs":2500,"num_of_blocks":100,"msgs":[{"weight":1,"type":"MsgMultiSend","num_of_recipients":100}]} |
|
Ironbird has started a testnet for chain Chain detailsChain: Version: Runner: Workflow ID: Run ID: Load test detailsLoad test config: |
|
/ironbird start simapp-v53 --load-test-config={"name":"unordered_test5","description":"unordered multisends","unordered_txs":false,"num_of_txs":2500,"num_of_blocks":100,"msgs":[{"weight":1,"type":"MsgMultiSend","num_of_recipients":100}]} |
|
Ironbird has started a testnet for chain Chain detailsChain: Version: Runner: Workflow ID: Run ID: Load test detailsLoad test config: |
|
/ironbird start simapp-v53 --load-test-config={"name":"unordered_test5","description":"unordered multisends","unordered_txs":false,"num_of_txs":2500,"num_of_blocks":100,"msgs":[{"weight":1,"type":"MsgMultiSend","num_of_recipients":100}]} |
|
Ironbird has started a testnet for chain Chain detailsChain: Version: Runner: Workflow ID: Run ID: Load test detailsLoad test config: |
|
/ironbird start simapp-v53 --load-test-config={"name":"unordered_test5","description":"unordered multisends","unordered_txs":false,"num_of_txs":2500,"num_of_blocks":100,"msgs":[{"weight":1,"type":"MsgMultiSend","num_of_recipients":100}]} |
|
Ironbird has started a testnet for chain Chain detailsChain: Version: Runner: Workflow ID: Run ID: Load test detailsLoad test config: |
|
/ironbird start simapp-v53 --load-test-config={"name":"unordered_test2","description":"unordered multisends","unordered_txs":false,"num_of_txs":2500,"num_of_blocks":100,"msgs":[{"weight":1,"type":"MsgMultiSend","num_of_recipients":100}]} |
|
Ironbird has started a testnet for chain Chain detailsChain: Version: Runner: Workflow ID: Run ID: Load test detailsLoad test config: |
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues. Your PR will not be merged unless you satisfy
all of these items.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdSummary by CodeRabbit