Skip to content

test: ironbird fixes [DNM] #24630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: ironbird fixes [DNM] #24630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/api/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ func (s *Server) Start(ctx context.Context, cfg config.Config) error {
// an error upon failure, which we'll send on the error channel that will be
// consumed by the for block below.
go func(enableUnsafeCORS bool) {
s.logger.Info("starting API server...", "address", cfg.API.Address)
s.logger.Info("starting ironbird API server...", "address", cfg.API.Address)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Ensure consistent branding across all API server log messages.

The startup log now includes “ironbird”, but the stopping ("stopping API server...") and error ("failed to start API server") logs still omit it. To maintain uniformity and improve clarity, update those messages to include “ironbird” as well (consider capitalizing “Ironbird” if that’s the intended branding).

🤖 Prompt for AI Agents (early access) 
In server/api/server.go at line 162, the startup log message includes "ironbird" but the stopping and error log messages do not. Update the stopping and error log messages to also include "Ironbird" with consistent capitalization to ensure uniform branding across all API server logs.


if enableUnsafeCORS {
allowAllCORS := handlers.CORS(handlers.AllowedHeaders([]string{"Content-Type"}))
Expand Down
Loading