Combine enhancements

[faddat]

• chore: modernize on the whole repo
• chore: update golangci-lint to v2
• upgrade golangci-lint-action
• upgrade more golangci-lint-action
• upgrade linter and add maintidx

[gjermundgaraba]

me gusta

Would be nice to do this without upgrading to go 1.24 just yet though. Ideally I want to do that together with the SDK upgrading to 1.24

[faddat]

@gjermundgaraba that'd change the set of changes, how about:

• make the changes 1.24 style
• drop to 1.23

....work for you?

[gjermundgaraba]

I am not sure I understand exactly what you mean by that. As long as the go version in go.mod and the github workflows stay at their current version I am good

[gjermundgaraba]

Heyo! Some of these have already been merged (golangci-lint and modernize). Something I think we still want to do is look into some of the new linters enabled in golangci-lint 2 and see if there are any reasonable ones we are missing. Looking at #8195, I'd say at least copyloopvar is needed

[faddat]

oh, OK :)

I will do the thing and nice work dude!

BTW, what's modernize?

[gjermundgaraba]

modernize is essentially applying the nest gopls modernize suggestions

[gjermundgaraba]

There has been quite a few changes that made some conflicts here. Not sure if you want to clean up the conflicts or open a new PR with just the linter additions? Would make the PR a bit cleaner potentially