chore: use a better name for main packages #543
Conversation
WalkthroughRemoved PR-only conditionals from two steps in the publish GitHub Actions workflow so they run unconditionally, and re-enabled previously skipped unit tests in the BridgingSdk test suites for BestQuoteStrategy and MultiQuoteStrategy. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub Actions
participant Job as publish-github-packages
Dev->>GH: Push / PR event
GH->>Job: Start workflow
Job->>Job: Determine is_pr (steps.version.outputs.is_pr)
rect rgba(220,235,255,0.25)
Note over Job: Previous (gated) flow
alt is_pr == 'true'
Job-->Job: Create pre-release versions (PR-only)
Job-->Job: Restore original versions (PR-only)
else
Job-->Job: Skip those steps
end
end
rect rgba(220,255,220,0.25)
Note over Job: New (ungated) flow
Job-->Job: Create pre-release versions (always)
Job-->Job: Restore original versions (always)
end
Job-->GH: Continue remaining steps (some still reference is_pr)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📦 GitHub Packages PublishedLast updated: Sep 26, 2025, 04:59:47 PM UTC The following packages have been published to GitHub Packages with pre-release version
InstallationThese packages require authentication to install from GitHub Packages. First, configure your token: # Set your GitHub token
# 1. create one at https://github.com/settings/tokens. Make sure you select the option "Generate new token (classic)"
# 2. Check only the "read:packages" scope
# 3. Add the token to the npm config
npm config set //npm.pkg.github.com/:_authToken YOUR_GITHUB_TOKENThen install any of the packages above: # Yarn
yarn add @cowprotocol/[email protected] --registry https://npm.pkg.github.com
# pnpm
pnpm install @cowprotocol/[email protected] --registry https://npm.pkg.github.com
# NPM
npm install @cowprotocol/[email protected] --registry https://npm.pkg.github.comView PackagesYou can view the published packages at: https://github.com/cowprotocol/cow-sdk/packages |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/bridging/src/BridgingSdk/strategies/MultiQuoteStrategy.test.ts (1)
28-28: Add afterEach to restore real timersSeveral tests inside this block switch to fake timers and rely on manually calling
jest.useRealTimers()at the end. If any of those assertions fail early, the suite will leak fake timers into subsequent tests, causing hard-to-track flakiness. Please add anafterEachguard to always restore real timers.describe(`MultiQuoteStrategy with ${adapterName}`, () => { + afterEach(() => { + jest.useRealTimers() + })
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/bridging/src/BridgingSdk/strategies/BestQuoteStrategy.test.ts(2 hunks)packages/bridging/src/BridgingSdk/strategies/MultiQuoteStrategy.test.ts(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
packages/bridging/src/BridgingSdk/strategies/MultiQuoteStrategy.test.ts (1)
packages/bridging/src/BridgingSdk/mock/bridgeRequestMocks.ts (1)
bridgeQuoteResult(127-161)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: eslint
- GitHub Check: Publish to GitHub Packages
- GitHub Check: test
- GitHub Check: Build Package
🔇 Additional comments (3)
packages/bridging/src/BridgingSdk/strategies/BestQuoteStrategy.test.ts (2)
27-27: Re-enabling BestQuoteStrategy adapter suite looks goodGlad to see this suite running again for every adapter—no concerns here.
125-125: Happy to see the execute suite back in rotationRe-enabling the core execution flow tests should help catch regressions early; LGTM.
packages/bridging/src/BridgingSdk/strategies/MultiQuoteStrategy.test.ts (1)
255-275: Async delay mocks remain correctThe expanded promise bodies keep the original behavior while making the resolution logic easier to read—looks good.
Attempt to fix the name used in the main branch when publishing packages to GH packages.
This is a follow up on: #539
The goal is to use
<version>-main-<hash>Summary by CodeRabbit
Chores
Tests