[crc-builder] vfkit ref configurable #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you need to add the param from here and then pass to the execution |
albfan
force-pushed
the
vkfit-ref
branch
2 times, most recently
from
284886d to
ccdd901
Compare
adrianriobo
reviewed
Feb 27, 2025
| @@ -115,6 +117,9 @@ spec: | |||
| if [[ $(params.crc-scm-pr) != "" ]]; then | |||
| cmd+="-crcSCMPR $(params.crc-scm-pr) " | |||
| fi | |||
| if [[ $(params.vfkit-scm-ref) != "" ]]; then | |||
There was a problem hiding this comment.
AS you have default value you can add the param directly... I would not expected anyone force the param from outside to ""
There was a problem hiding this comment.
thanks for confirmation, I was roundting the idea, but not sure. Will rework it
lilyLuLiu
reviewed
Feb 27, 2025
| @@ -68,6 +68,8 @@ spec: | |||
| default: https://github.com/code-ready/crc.git | |||
| - name: crc-scm-ref | |||
| default: main | |||
| - name: vfkit-scm-ref | |||
| default: main | |||
There was a problem hiding this comment.
Considering that we will use the 'go-1.22' branch instead of 'main'. I suggest using go-1.22as default value.
This will avoid modification on pipelines to setup this new added parameter.
There was a problem hiding this comment.
nice, that would make all easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to build different branches on vfkit