Fix misc build issues by cfergeau · Pull Request #57 · crc-org/routes-controller

cfergeau · 2026-06-23T09:08:15Z

Following the golangci-lint changes, more adjustment are needed, mostly related to the go version used for building. This should fix CI builds.

gha: Stop using go-version-file: go.mod
build: Require go 1.25 or newer
build: make default target should be build

Summary by CodeRabbit

Chores
- Updated Go toolchain to version 1.25 for improved performance and compatibility.
- Streamlined build automation and continuous integration workflow.
- Set default build target for improved developer experience.

coderabbitai · 2026-06-23T09:08:34Z

Warning

Review limit reached

@cfergeau, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 51 minutes and 54 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: efcf55b7-ab0e-4e85-8259-c09df1de9f90

📥 Commits

Reviewing files that changed from the base of the PR and between 6bd95c9 and d810a36.

📒 Files selected for processing (3)

.github/workflows/ci.yml
Makefile
go.mod

Walkthrough

Go module directive updated from 1.23.0 to 1.25 in go.mod. The CI workflow's lint and test jobs no longer supply go-version-file: go.mod to actions/setup-go. The Makefile gains .DEFAULT_GOAL := build.

Changes

Go toolchain upgrade and build config

Layer / File(s)	Summary
Go 1.25 bump and CI version input removal `go.mod`, `.github/workflows/ci.yml`	`go` directive bumped from `1.23.0` to `1.25` in `go.mod`; `go-version-file: go.mod` inputs removed from both the `lint` and `test` setup-go steps in the CI workflow.
Makefile default goal `Makefile`	`.DEFAULT_GOAL := build` added so `make` without arguments invokes the `build` target.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A hop to Go 1.25, so sleek and new,
The version file bid the CI adieu,
With .DEFAULT_GOAL the Makefile gleams,
Build by default — just what the rabbit dreams!
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Fix misc build issues' is vague and generic, using non-descriptive language that doesn't convey the specific nature of the changes made.	Use a more specific title that captures the main change, such as 'Update Go version to 1.25 and fix build configuration' or 'Remove go-version-file from CI and update Go toolchain version'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

`go.mod` files use full go versions (1.2x.0) these days, and in this case, `go-version-file` will instruct the `setup-go` action to use exactly this version, why the desired behaviour would be to use the latest patch release (ie newest 1.2x.y). This commit uses the oldest stable release of go instead (latest 1.25.x at the time of this commit). Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

go 1.25 is the oldest supported go release. `tools/go.mod` already requires go 1.25 Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

With the `golangci-lint` changes, the default target is now `golangci-lint` build through the inclusion of `tools.mk`, which was not intentional. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

At the moment, this job is not doing anything… Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

`make test` and `make lint` may be testing `routes-controller` build, but I prefer to have an explicit job testing the build. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

cfergeau · 2026-06-23T09:19:00Z

Phew, finally all green !

praveenkumar · 2026-06-23T09:26:25Z

 module github.com/crc-org/routes-controller

-go 1.23.0
+go 1.25


shouldn't with this change we also update the gh action file to use 1.25 instead of oldstable ?

praveenkumar · 2026-06-23T09:27:01Z

+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v6
+        with:
+          go-version: oldstable


here also we are using oldstable does it the stable of 1.25.x ?

my assumption is that oldstable == 1.25.x, and stable == 1.26.x
https://github.com/crc-org/routes-controller/actions/runs/28015680805/job/82919263700 has this in the logs:

Run actions/setup-go@v6 Setup go version spec oldstable oldstable version resolved as 1.25.11

So the assumption seems correct.
But even if in the future we stick to 1.25 in go.mod, I think it’s fine to build with oldstable rather than hardcoding 1.25 to ensure routes-controller is buildable with a supported golang version

praveenkumar · 2026-06-23T12:45:51Z

+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v6
+        with:
+          go-version: oldstable


cfergeau added 3 commits June 23, 2026 11:11

build: Require go 1.25 or newer

c6c6635

go 1.25 is the oldest supported go release. `tools/go.mod` already requires go 1.25 Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

build: make default target should be build

791bd03

With the `golangci-lint` changes, the default target is now `golangci-lint` build through the inclusion of `tools.mk`, which was not intentional. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

cfergeau force-pushed the fix_ci branch from 6bd95c9 to 791bd03 Compare June 23, 2026 09:12

cfergeau added 2 commits June 23, 2026 11:14

gha: Actually run make lint in the Lint job

222f6bb

At the moment, this job is not doing anything… Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

gha: Add Build job

d810a36

`make test` and `make lint` may be testing `routes-controller` build, but I prefer to have an explicit job testing the build. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

praveenkumar reviewed Jun 23, 2026

View reviewed changes

praveenkumar approved these changes Jun 23, 2026

View reviewed changes

praveenkumar merged commit 4d30088 into crc-org:master Jun 23, 2026
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix misc build issues#57

Fix misc build issues#57
praveenkumar merged 5 commits into
crc-org:masterfrom
cfergeau:fix_ci

cfergeau commented Jun 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading

Review limit reached

❌ Failed checks (1 inconclusive)

Uh oh!

cfergeau commented Jun 23, 2026

Uh oh!

praveenkumar Jun 23, 2026

Uh oh!

praveenkumar Jun 23, 2026

Uh oh!

cfergeau Jun 23, 2026

Uh oh!

praveenkumar Jun 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

cfergeau commented Jun 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

cfergeau commented Jun 23, 2026

Uh oh!

praveenkumar Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

praveenkumar Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

cfergeau Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

praveenkumar Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cfergeau commented Jun 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading