Skip to content

Fix misc build issues #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praveenkumar merged 5 commits into from
Jun 23, 2026
Merged

Fix misc build issues #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6103a5d
gha: Stop using `go-version-file: go.mod`
cfergeau Jun 23, 2026
c6c6635
build: Require go 1.25 or newer
cfergeau Jun 23, 2026
791bd03
build: `make` default target should be `build`
cfergeau Jun 23, 2026
222f6bb
gha: Actually run `make lint` in the `Lint` job
cfergeau Jun 23, 2026
d810a36
gha: Add `Build` job
cfergeau Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,24 @@ concurrency:
cancel-in-progress: true

jobs:
build:
name: Build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v6
with:
go-version: oldstable

@praveenkumar praveenkumar Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here also we are using oldstable does it the stable of 1.25.x ?

@cfergeau cfergeau Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my assumption is that oldstable == 1.25.x, and stable == 1.26.x
https://github.com/crc-org/routes-controller/actions/runs/28015680805/job/82919263700 has this in the logs:

Run actions/setup-go@v6
Setup go version spec oldstable
oldstable version resolved as 1.25.11

So the assumption seems correct.
But even if in the future we stick to 1.25 in go.mod, I think it’s fine to build with oldstable rather than hardcoding 1.25 to ensure routes-controller is buildable with a supported golang version

@praveenkumar praveenkumar Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

- run: make

lint:
name: Lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v6
with:
go-version-file: go.mod
go-version: oldstable
- run: make lint

test:
Expand All @@ -27,5 +37,5 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v6
with:
go-version-file: go.mod
go-version: oldstable
- run: make test
2 changes: 2 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
.DEFAULT_GOAL := build

TOOLS_DIR := tools
include tools/tools.mk

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/crc-org/routes-controller

go 1.23.0
go 1.25

@praveenkumar praveenkumar Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't with this change we also update the gh action file to use 1.25 instead of oldstable ?


require (
github.com/openshift/api v0.0.0-20250305013520-e7f23be12279
Expand Down
Loading