allow to pass user/meta data files for cloud-init config #263
Conversation
|
Skipping CI for Draft Pull Request. |
cmd/vfkit/main.go
Outdated
| return "", err | ||
| } | ||
|
|
||
| // based on the file name we save its content on the corresponding var |
There was a problem hiding this comment.
is it possible to use marshalling to determine the type?
There was a problem hiding this comment.
user-data can be written using different formats so I think it is easier to rely on the file name.
Cloud-init expects a user-data and meta-data files (they are mandatory) so asking the user to pass files with those names does not seem an absurdity
cmd/vfkit/main.go
Outdated
| return "", errors.Wrap(err, "unable to fetch user cache dir") | ||
| } | ||
|
|
||
| isoFilePath := filepath.Join(cacheDir, "vfkit-cloudinit.iso") |
There was a problem hiding this comment.
is this file deleted after vfkit exits? If not, I wonder if that filename should be somehow different per run? I dont know the origin of cachedir, so if the runs are namespaced, then you are probably cool. But I was thinking of a scneario where two vms are run, both with cloud-init, would they overwrite eachother?
There was a problem hiding this comment.
yes, updated. It was fixed on that specific path bc of some specific script I was using for testing 👍
but yes, there is no reason to keep it fixed, updated to a random filename
|
really cool idea ... i like where you are taking this. couple of questions from me bc I had to make some assumptions without a PR/commit message (hint hint) |
yes, sorry. I just pushed the code to keep track of it but it was non-working code. Now it is fixed. I added a commit message 👍 |
| } | ||
|
|
||
| if userDataReader == nil && metaDataReader == nil { | ||
| return "", fmt.Errorf("cloud-init needs user-data and meta-data files to work") |
There was a problem hiding this comment.
I'm a bit confused by the error message and the test. If I'm not mistaken, the test implies that we need user-data or meta-data to be provided, but the way I understand the error message, we expect to get both?
There was a problem hiding this comment.
Cloud-init requires both files to work. They can be empty but they must exist otherwise it won't work.
However I think it's reasonable to allow the user to only pass one file. Maybe you just need to push some customization using the user-data (or the meta-data) and leave the other file empty. This way if we find out that you only have the user-data, we create an empty meta-data file (or vice versa).
On the other hand, if we do not find any of those files, there is most probably an error and the user needs to be informed
There was a problem hiding this comment.
should the input be a dir that contains files and we check for meta and user data as a minimum and proceed? or is it common to have multiples of those? (when I was a cloud-init expert in the day, it was just mostly those two)
There was a problem hiding this comment.
i am using this stuff in another tool and I thought the same thing.
Would it be acceptable to allow the user to pass a folder or files? Or would it be confusing?
--cloud-init <folder-path>
and also
--cloud-init <folder-path>/userdata,<other-folder>/meta-data
lstocchi
force-pushed
the
i208
branch
2 times, most recently
from
a62bde9 to
4e8f093
Compare
go.mod
Outdated
| @@ -53,7 +55,6 @@ require ( | |||
| github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect | |||
| github.com/modern-go/reflect2 v1.0.2 // indirect | |||
| github.com/pelletier/go-toml/v2 v2.2.2 // indirect | |||
| github.com/pkg/errors v0.9.1 // indirect | |||
There was a problem hiding this comment.
This change is unexpected now that you no longer use pkg/errors, maybe go mod tidy changes it back?
this patch allows vfkit to accept raw cloud-init config files to customize the VM. It uses those files to generate an ISO image and inject it using virtio-blk device (crc-org@0ae085d) The supported and expected files are user-data and meta-data. As user-data can be written in different formats (https://cloudinit.readthedocs.io/en/latest/explanation/format.html) vfkit relies on the file names to detect them. If the user do not pass user-data or meta-data, an empty file with that name will be added into the ISO image. Vfkit deletes the cloud-init ISO file when it exits Signed-off-by: Luca Stocchi <[email protected]>
Signed-off-by: Luca Stocchi <[email protected]>
Signed-off-by: Luca Stocchi <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
with crc-org/vfkit#263 and cfergeau/podman#3 we can leverage cloud-init to inject ssh key into a rhel vm. this patch allows to set the cloudinit flag from macadam that would define if the vm should be customized by using cloud-init or the default ignition. Signed-off-by: Luca Stocchi <[email protected]>
with crc-org/vfkit#263 and cfergeau/podman#3 we can leverage cloud-init to inject ssh key into a rhel vm. this patch allows to set the cloudinit flag from macadam that would define if the vm should be customized by using cloud-init or the default ignition. Signed-off-by: Luca Stocchi <[email protected]>
this patch allows vfkit to accept raw cloud-init config files to customize the VM.
It uses those files to generate an ISO image and inject it using virtio-blk device (0ae085d)
The supported and expected files are user-data and meta-data.
As user-data can be written in different formats (https://cloudinit.readthedocs.io/en/latest/explanation/format.html)
vfkit relies on the file names to detect them.
If the user do not pass user-data or meta-data, an empty file with that name will be added into the ISO image.
Vfkit deletes the cloud-init ISO file when it exits