Skip to content

Conversation

@krvstek
Copy link
Contributor

@krvstek krvstek commented Sep 24, 2025

No description provided.

@kitadai31
Copy link
Contributor

Are the Bring back twitter strings correct?

I reference the strings in Twitter 9.98.0.
tweets_retweet is Podaj dalej
tweets_retweeted is %s podał/a dalej Tweeta

As far as I know, these strings do not necessarily need to match the 9.98.0 version exactly, but I think it is better to use the official names in your language for proper nouns like “Tweet” and “Retweet” so that users can actually go back to old twitter.

Also, you must add a backslash before double quotes in strings.xml
Same as single quotes

@krvstek
Copy link
Contributor Author

krvstek commented Sep 26, 2025

Are the Bring back twitter strings correct?

I reference the strings in Twitter 9.98.0. tweets_retweet is Podaj dalej tweets_retweeted is %s podał/a dalej Tweeta

As far as I know, these strings do not necessarily need to match the 9.98.0 version exactly, but I think it is better to use the official names in your language for proper nouns like “Tweet” and “Retweet” so that users can actually go back to old twitter.

Also, you must add a backslash before double quotes in strings.xml Same as single quotes

I didn't take the official names, when adding this translation to the patch, as I had no idea those terms were actually translated in the original app. As for the backslashes: I just followed the original translation and from what I can see, there are no backslashes before double quotes in the file.

I'll apply a fix for this as soon as I can.

@krvstek krvstek closed this Sep 26, 2025
@krvstek krvstek deleted the dev branch September 26, 2025 06:02
@kitadai31
Copy link
Contributor

I didn't take the official names, when adding this translation to the patch, as I had no idea those terms were actually translated in the original app.

Alright
I don't know how those words are actually used among Polish speakers, and I'm not a maintainer anyway, so please take this as just a reference.

As for the backslashes: I just followed the original translation and from what I can see, there are no backslashes before double quotes in the file.

Wow, that's true

<string name="piko_pref_wtf_section">"Who to follow" section</string>
<string name="piko_pref_cts_section">"Creators to subscribe" section</string>
<string name="piko_pref_ctj_section">"Community to join" section</string>
<string name="piko_pref_ryb_section">"Revisit your bookmark" section</string>
<string name="piko_pref_pinned_posts_section">"Pinned posts by followers" section</string>

Has nobody noticed until now? lol
As shown in this image, without the backslash the double quotes will not be displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants