fix(api): apply filename query to recording download, do not clobber instance selector query param #1937
+15
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instance selector query param
|
This PR/issue depends on: |
Merged
7 tasks
Josh-Matsuoka
approved these changes
Nov 20, 2025
7 tasks
andrewazores
added a commit
that referenced
this pull request
Nov 21, 2025
…instance selector query param (#1937) (#1938) (cherry picked from commit baf0125) Co-authored-by: Andrew Azores <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated to cryostatio/cryostat#1171
Depends on cryostatio/cryostat#1171
Description of the change:
Applies the same
filenamequery parameter handling so that the backend sets theContent-Dispositionheader accordingly.More importantly, updates the
filenamequery parameter handling so not always hardcode the?query string separator, and to only infix it if needed. Otherwise, when the Cryostat UI is running within an OpenShift Console Plugin context, the query string construction may conflict with the console proxy instance selector query string construction.