Update linters and actions #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdpiper
added a commit
that referenced
this pull request
May 2, 2025
* Update pre-commit hooks * Clean lint with updated pre-commit hooks * Allow E704, multiple definitions per line * Manually clean lint found by flake8 * Make test-notebooks job cancelable * Use setup-python action instead of setup-miniconda * Use the conda-forge channel to find nbmake * Also use conda-forge channel for requirements * Clean lint with pre-commit hooks * Replace invalid API key with demo key * Use python=3.13 * Use latest versions of landlab and pymt * Clean lint
mdpiper
added a commit
that referenced
this pull request
May 2, 2025
* reset cel output & renamed hillslope_functions notebook * Updated diffusion and functino notebooks * Update linters and actions (#157) * Update pre-commit hooks * Clean lint with updated pre-commit hooks * Allow E704, multiple definitions per line * Manually clean lint found by flake8 * Make test-notebooks job cancelable * Use setup-python action instead of setup-miniconda * Use the conda-forge channel to find nbmake * Also use conda-forge channel for requirements * Clean lint with pre-commit hooks * Replace invalid API key with demo key * Use python=3.13 * Use latest versions of landlab and pymt * Clean lint * Disable nbqa-isort, fighting with black * Clean lint with pre-commit hooks * Disable flake8 rule F821 It's giving incorrect info about undefined variable names that are defined in cells upstream. * Change variable name from l to lx flake8 was warning about an ambiguous variable name, since "l" could be interpreted as "1". * Skip tests on hillslope notebooks We can come back later to get them working with tests. --------- Co-authored-by: Mark Piper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the linters and actions we use in our CI workflow.
Tasks addressed include: