[pull] master from paritytech:master #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ueue (#10906) This PR removes the stale pending collations from the waiting queue when the peer that advertised the collation disconnects. When the peer reconnects, the peer data is freshly created without any prior information about advertised collations. Then the state-pending collation is picked from the queue. The network request will not be emitted since the `fn fetch_collation` sees no prior advertisement via `peer_data.has_advertised` and returns `Err(FetchError::NotAdvertised)`. To avoid this, remove the stale entries immediately when the peer disconnects. Part of the stabilization of: - #10425 --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
#10698) fixes #8364 This PR adds compile-time tests using try_build to validate invariants enforced on registered precompiles. The tests ensure collision detection and related compile-time checks are correctly triggered and remain enforced. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: PG Herveou <[email protected]> Co-authored-by: xermicus <[email protected]>
by default rustfmt preserve local style, and Claude loves to add semi or bracket where there were none before, We should make the formatting more strict as this is a bit annoying to remind it constantly not to make unnecessary diff. ## Summary The PR is just updating https://github.com/paritytech/polkadot-sdk/blob/pg/stricter-rustfmt-rules/.rustfmt.toml every other changes are just the result of running the linter - Change `match_arm_leading_pipes` from "Preserve" to "Never" to enforce a single style - Change `trailing_semicolon` from false to true to enforce `return 42;` false unfortunately preserve the local style - Add `normalize_comments = true` to normalize comment spacing (e.g., `// comment` not `//comment`) - Add `normalize_doc_attributes = true` to enforce `///` over `#[doc = ""]` These changes ensure only one valid formatting style exists, reducing unnecessary diffs in pull requests caused by different but equally valid formatting styles. ## Not changed (for now) The following options also default to "Preserve" but were intentionally not changed due to (even) larger diff impact: - `group_imports` - Would enforce import grouping order (std → external → crate) but causes massive import reordering across the codebase - `hex_literal_case` - Would enforce `0xABCD` vs `0xabcd` consistency - edition 2024 - not sure what that change but it also probably create a big diff These could be considered in a future PR if the one-time diff cost is acceptable. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
) There's a possible race case between peer connectivity and collation advertisement: - The advertisement was generated - peer disconnected before receiving the advertisement As a result of that, when the peer reconnects, the previous collation (C0) is not sent. This happens when the collator has produced another collation (C1). However, from the logs it looks like the collation C1 is advertising, but C0 is skipped. - T0: peer disconnects without receiving C0 - T1: peer reconnects - T2: collator advertises C1, but not C0 This PR aims to resubmit collations on `PeerConect` events to mitigate these cases Closes #10463 --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <[email protected]>
This PR downgrade the telemetry warning log to debug. - The log is causing a lot of noise in our test nets: https://grafana.teleport.parity.io/goto/fjTQ_vzDg?orgId=1 --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…st (#10886) Under load, 5 seconds might not be enough for the CI to capture all events generated by the net backend. In this PR, the timeout is increased to 60s after which a hard panic occurs. Discovered during: - #10846 Signed-off-by: Alexandru Vasile <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )